Skip to content

Fix: check restart file reading and fix MPI datatype mismatch for bool flag #7660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 7 commits into from
Jul 24, 2026
+10 −2
Merged

Fix: check restart file reading and fix MPI datatype mismatch for bool flag #7660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
254a17f
fix: resolve undefined variable and early termination in aveElecStatP…
DanielZhao0432 Jul 15, 2026
66d2960
Merge pull request #1 from DanielZhao0432/DanielZhao0432-fix-pot-script
DanielZhao0432 Jul 20, 2026
40654d5
Fix file reading and MPI_Bcast type
DanielZhao0432 Jul 20, 2026
5282a08
Update msst.cpp
DanielZhao0432 Jul 20, 2026
39d4e82
Fix file reading condition in fire.cpp
DanielZhao0432 Jul 21, 2026
30d2709
Fix file reading condition in msst.cpp
DanielZhao0432 Jul 21, 2026
6451864
Merge branch 'develop' into develop
DanielZhao0432 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/source_md/fire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,16 @@ void FIRE::restart(const std::string& global_readin_dir)
if (ok)
{
file >> step_rst_ >> md_tfirst >> alpha >> negative_count >> dt_max >> md_dt;
if(!file)
{
ok = false;
}
file.close();
}
}

#ifdef __MPI
MPI_Bcast(&ok, 1, MPI_INT, 0, MPI_COMM_WORLD);
MPI_Bcast(&ok, 1, MPI_C_BOOL, 0, MPI_COMM_WORLD);
#endif

if (!ok)
Expand Down
6 changes: 5 additions & 1 deletion source/source_md/msst.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,16 @@ void MSST::restart(const std::string& global_readin_dir)
if (ok)
{
file >> step_rst_ >> md_tfirst >> omega[mdp.msst_direction] >> e0 >> v0 >> p0 >> lag_pos;
if(!file)
{
ok = false;
}
file.close();
}
}

#ifdef __MPI
MPI_Bcast(&ok, 1, MPI_INT, 0, MPI_COMM_WORLD);
MPI_Bcast(&ok, 1, MPI_C_BOOL, 0, MPI_COMM_WORLD);
#endif

if (!ok)
Expand Down
Loading