Update Editor HTTP API commands and responses for 1.13.2 - #680
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 452c4e28d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| curl -sS \ | ||
| -X POST \ | ||
| "$BASE_URL/command/build-html5" | ||
| "$BASE_URL/command/build-html5" | | ||
| jq |
There was a problem hiding this comment.
Expose HTTP failures in the HTML5 command example
When the build returns the documented structured 422 response, this pipeline can still exit successfully: curl -sS does not fail on HTTP error statuses, and the final jq supplies the pipeline exit status. I checked curl --help all: -s is only “Silent mode,” while -f/--fail-with-body handles HTTP errors and -w exposes response metadata. Automation following this example therefore cannot perform the next paragraph's required HTTP-status check and may proceed to browser tests after a failed build; capture and test the status while preserving the response body.
Useful? React with 👍 / 👎.
The Editor HTTP API manual still discovers commands through
/command/{command}and describes completed HTML5 builds as HTTP 202. Update the guidance for Defold 1.13.2 so integrations discover individual command paths, choose compile-only or compile-and-run, and handle completed build results correctly.Technical changes
/command/buildexamples with/command/compileand/command/run.Validation
git diff --checkpassed.be31a20289817d06f568449dbc1463e2d000eaaf.Based on the Defold 1.13.2 beta release notes.