fix(http): evaluate cache validators for HEAD requests - #7329
Open
dennisimoo wants to merge 1 commit into
Open
dennisimoo wants to merge 1 commit into
dennisimoo wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7329 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 618 618
Lines 51746 51746
Branches 9402 9402
=======================================
Hits 49181 49181
Misses 2022 2022
Partials 543 543 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7327.
Move the existing HEAD response below cache-validator evaluation, while keeping it before Range handling and file opening. Conditional HEAD requests now return
304like GET, as required by RFC 9110 §13.2.2.Tests cover matching ETags,
*, modified-since dates, ETag precedence, ignored Range headers andserveDir(). Both regressions fail before the fix.Tests:
deno test -A --doc http/— 479 passed, 987 steps, 2 ignored. Lint and formatting passed. Full-suite verification is memory-limited: the sibling branch'sdeno task okwas killed in an unrelated CBOR test allocating 4–8 GiB; this branch's full run was stopped before repeating that allocation.AI-assisted with Codex.