Skip to content

Support optional argument prefixes for container runtimes - #1304

Open
Shawn Yuan (shuaiyuanxx) wants to merge 1 commit into
devcontainers:mainfrom
shuaiyuanxx:user/shawn/wslc-debug-support-session-args
Open

Shawn Yuan (shuaiyuanxx) wants to merge 1 commit into
devcontainers:mainfrom
shuaiyuanxx:user/shawn/wslc-debug-support-session-args

Conversation

@shuaiyuanxx

@shuaiyuanxx Shawn Yuan (shuaiyuanxx) commented Sep 17, 2026

Copy link
Copy Markdown

Summary

Adds an optional, repeatable --runtime-arg option to set-up and run-user-commands.

This enables Dev Containers to target existing WSLC SDK Sessions using wslc --session <name>.

This PR needs to be used together with this dev container PR

Changes

  • Preserve runtime arguments through setup, lifecycle commands, runtime probes, and internal exec/PTY operations.
  • Keep existing behavior when the option is omitted.
  • Limit support to the two commands used by the attachment flow.

Example

devcontainer set-up \
  --docker-path wslc \
  --runtime-arg=--session \
  --runtime-arg="SDK Session" \
  --container-id CONTAINER_ID

Validation

  • Focused tests, type checking, lint, and build passed.
  • Verified both commands against an SDK-created container.
  • Verified missing-session rejection and VS Code attachment, terminal access, and reload with the paired extension.

@shuaiyuanxx
Shawn Yuan (shuaiyuanxx) requested a review from a team as a code owner September 17, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant