Skip to content

#2251: add uninstall support for global tools windows - #2301

Merged
hohwille merged 4 commits into
devonfw:mainfrom
cap-juan:feature/2251-uninstall-global-tools-windows
Aug 21, 2026
Merged

#2251: add uninstall support for global tools windows#2301
hohwille merged 4 commits into
devonfw:mainfrom
cap-juan:feature/2251-uninstall-global-tools-windows

Conversation

@cap-juan

@cap-juan cap-juan commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2251

Implemented changes:

  • Use getWindowsRegistryAppName() instead of the generic tool name when uninstalling global tools on Windows.
  • This ensures that the same registry application name used for installation detection is also used to locate the correct uninstall entry.

Testing instructions

  1. Build IDEasy locally while executing ./build-local-dev.sh.
  2. Install a supported global tool on Windows e.g. ide install pgAdmin.
  3. Run ide -d uninstall pgadmin.
  4. Verify that IDEasy detects the installed pgAdmin application via the Windows registry and starts the uninstall process instead of reporting "Couldn't uninstall pgadmin because we could not find an installation"

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Aug 10, 2026
@cap-juan
cap-juan force-pushed the feature/2251-uninstall-global-tools-windows branch 2 times, most recently from 86cac90 to 15b6180 Compare August 10, 2026 12:52
@cap-juan cap-juan changed the title Feature/2251 uninstall global tools windows Feature/2251 add uninstall support for global tools windows Aug 10, 2026
@cap-juan cap-juan moved this from 🆕 New to Team Review in IDEasy board Aug 10, 2026
@cap-juan cap-juan self-assigned this Aug 10, 2026
@cap-juan cap-juan added enhancement New feature or request windows specific for Microsoft Windows OS uninstall uninstall tools or IDEasy itself labels Aug 10, 2026
@cap-juan
cap-juan force-pushed the feature/2251-uninstall-global-tools-windows branch from 15b6180 to cbae6d3 Compare August 10, 2026 12:58
@coveralls

coveralls commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 32500376926

Coverage decreased (-0.008%) to 73.497%

Details

  • Coverage decreased (-0.008%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 44 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

44 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/os/WindowsHelperImpl.java 41 51.92%
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 2 8.2%
com/devonfw/tools/ide/version/VersionSegment.java 1 91.86%

Coverage Stats

Coverage Status
Relevant Lines: 18030
Covered Lines: 13855
Line Coverage: 76.84%
Relevant Branches: 8005
Covered Branches: 5280
Branch Coverage: 65.96%
Branches in Coverage %: Yes
Coverage Strength: 3.28 hits per line

💛 - Coveralls

@hohwille hohwille changed the title Feature/2251 add uninstall support for global tools windows #2251: add uninstall support for global tools windows Aug 11, 2026
@cap-juan
cap-juan force-pushed the feature/2251-uninstall-global-tools-windows branch from cbae6d3 to bab534c Compare August 11, 2026 07:41
@krystynaShatkovska
krystynaShatkovska self-requested a review August 13, 2026 10:11
@krystynaShatkovska

Copy link
Copy Markdown
Contributor

Good work. All unit tests are passed. Could not test with pgAdmin installation as it does not work in my enviroment

@krystynaShatkovska krystynaShatkovska moved this from Team Review to 👀 In review in IDEasy board Aug 14, 2026
@JoelAdbu JoelAdbu moved this from 👀 In review to Team Review in IDEasy board Aug 14, 2026
@JoelAdbu JoelAdbu self-assigned this Aug 14, 2026

@JoelAdbu JoelAdbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested the installation and uninstallation of pgAdmin. Everything works perfectly. Well done!

@JoelAdbu JoelAdbu moved this from Team Review to 👀 In review in IDEasy board Aug 14, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cap-juan thanks for your PR. Your approach looks good and make fully sense 👍
I left some comments for improvement. Please address so we can merge.

Comment thread cli/src/main/java/com/devonfw/tools/ide/os/WindowsHelperImpl.java Outdated
Comment thread cli/src/test/java/com/devonfw/tools/ide/os/WindowsHelperImplTest.java Outdated
Comment thread CHANGELOG.adoc Outdated
@hohwille hohwille added this to the release:2026.08.002 milestone Aug 18, 2026
@cap-juan
cap-juan force-pushed the feature/2251-uninstall-global-tools-windows branch from d71bffc to 540baa5 Compare August 20, 2026 07:25
@cap-juan
cap-juan force-pushed the feature/2251-uninstall-global-tools-windows branch from 540baa5 to f5a0c57 Compare August 20, 2026 07:28

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cap-juan thanks for the rework. All perfect now. 👍
There were some conflicts that I hopefully resolved carefully and correctly.
Will now merge.

@hohwille
hohwille merged commit b034eae into devonfw:main Aug 21, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request uninstall uninstall tools or IDEasy itself windows specific for Microsoft Windows OS

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Provide generic uninstall support for globally installed tools (Windows)

5 participants