#694 Improved dotnet installation - #2341
Conversation
Coverage Report for CI Build 32468040568Coverage increased (+0.02%) to 72.959%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
|
Thanks for the PR. Aside from the wrong positioning of the Changelog entry, I tested the changes on both Windows and Linux (WSL).Here are my findings: My Suggestions, Could you please double-check the command on Linux? If this requires specific local setup, it would be great to update the PR description with the necessary prerequisites for testing. |
I think we need to give this an extra look. I'm testing on Arch, could it be something to do with WSL? Regardless, I'll give it a proper look tomorrow morning |
This PR fixes #694
Implemented changes:
Testing instructions
Run the cli configuration with the following:
uninstall dotnetinstall dotnetenvide dotnet --infoChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc