fix: fix potential infinite event queue buffering - #706
Draft
adamspofford-dfinity wants to merge 3 commits into
Draft
fix: fix potential infinite event queue buffering#706adamspofford-dfinity wants to merge 3 commits into
adamspofford-dfinity wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents managed launcher file watchers from hanging during shutdown when event channels are full.
Changes:
- Groups watchers and receivers to enforce safe drop order.
- Adds watcher completion and shutdown regression tests.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+372
to
+377
| let mut session = WatchSession { | ||
| rec_rx, | ||
| poll_rx, | ||
| _rec_watcher: rec_watcher, | ||
| _poll_watcher: poll_watcher, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.