Conversation
Goooler
marked this pull request as draft
September 8, 2026 16:11
3 tasks
Goooler
force-pushed
the
g/20260908/java-25-26
branch
2 times, most recently
from
September 11, 2026 07:49
8372170 to
fbadc0f
Compare
Goooler
commented
Sep 11, 2026
| private void addAndCommit(Git git, String message) throws GitAPIException { | ||
| git.add().addFilepattern(".").call(); | ||
| git.commit().setMessage(message).call(); | ||
| git.commit().setSign(false).setMessage(message).call(); |
Member
Author
There was a problem hiding this comment.
Fixes test failures on my machines like, as I enabled commit.gpgsign in ~/.gitconfig.
Goooler
force-pushed
the
g/20260908/java-25-26
branch
from
September 11, 2026 08:07
fbadc0f to
328729e
Compare
Goooler
force-pushed
the
g/20260908/java-25-26
branch
from
September 11, 2026 08:39
328729e to
42c44b4
Compare
Member
|
This LGTM. Feel free to merge if it looks ready to you. I think we should publish a release soon, maybe as soon as these two get merged
Anything else you'd like to see get merged before the next release? |
Goooler
marked this pull request as ready for review
September 15, 2026 00:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.