Skip to content

CODE: update pre-commit hooks#302

Open
stevengeorge128 wants to merge 1 commit into
diffpy:mainfrom
stevengeorge128:precommit-hook-update
Open

CODE: update pre-commit hooks#302
stevengeorge128 wants to merge 1 commit into
diffpy:mainfrom
stevengeorge128:precommit-hook-update

Conversation

@stevengeorge128

Copy link
Copy Markdown

Updated the pre-commit hook versions according to the recent Slack discussion and applied the resulting formatting/linting changes.

One remaining issue is a formatting conflict between black and docformatter affecting the following files:

  • src/diffpy/pdfgui/gui/tooltips.py
  • src/diffpy/pdfgui/control/fitdataset.py
  • src/diffpy/pdfgui/control/fitstructure.py

In each case, the conflict is the same: black and docformatter repeatedly move the comma following a multiline triple-quoted string, preventing pre-commit from passing.

@stevengeorge128

Copy link
Copy Markdown
Author

@stevenhua0320, ready to review

@stevenhua0320

stevenhua0320 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

You could remove the comma to make it not conflict for the pre-commit hook. The purpose now is to make the pre-commit workflow passing. Also, per our convention, we would make the title with chore: ... More details about how we name these is documented in the scikit-package webpage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants