Replace RPC with native Zenoh RPC - DIM-1145#3176
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Greptile SummaryReplaces the pub/sub-emulated Zenoh RPC backend with native Zenoh queryables and queries.
Confidence Score: 5/5The PR appears safe to merge with no blocking failures remaining from the eligible follow-up threads. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Zenoh
participant Server
Client->>Zenoh: "get dimos/rpc/{name}"
Zenoh->>Server: Query(payload)
Server->>Server: Execute handler in thread pool
alt successful call
Server-->>Zenoh: reply(serialized result)
Zenoh-->>Client: on_reply(result)
else handler exception
Server-->>Zenoh: reply_err(serialized exception)
Zenoh-->>Client: on_reply(error)
else query completes without response
Zenoh-->>Client: on_finalize()
Client->>Zenoh: retry until RPC deadline
end
Reviews (2): Last reviewed commit: "- create dimos/protocol/rpc/zenohrpc.py" | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3176 +/- ##
========================================
Coverage 74.17% 74.18%
========================================
Files 1108 1109 +1
Lines 104052 104157 +105
Branches 9530 9545 +15
========================================
+ Hits 77179 77266 +87
- Misses 24129 24140 +11
- Partials 2744 2751 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
- cutover imports and delete the emulated ZenohRPC - eclipse-zenoh version floor + uv lock + docs line
fc5a49d to
f03d851
Compare
No description provided.