codebase_checks: make whitelist path matching OS-agnostic#3179
Open
xiaoyaoqilan wants to merge 1 commit into
Open
codebase_checks: make whitelist path matching OS-agnostic#3179xiaoyaoqilan wants to merge 1 commit into
xiaoyaoqilan wants to merge 1 commit into
Conversation
The WHITELIST path comparisons in test_get_logger, test_no_sections,
and test_no_dunder_new compare `rel_path` against "/" - hardcoded paths.
But `rel_path` is built from `os.path.relpath` / `Path.relative_to`,
which yield OS-native separators ("\\" on Windows). On any OS where
`os.sep != "/"`, the comparison never matches, so the whitelist is
dead code: it masks real violations and reports spurious ones.
test_no_get_logger currently fails on Windows with 8 false positives
(the 8 whitelisted `logging.getLogger` usages all get flagged). The
same latent bug affects test_no_sections (docker_module.py sentinel)
and test_no_dunder_new (mujoco __new__).
Normalize `rel_path` to forward slashes before comparing. No-op on
Linux/macOS, correct everywhere. Verified: the three checks now pass
on Windows and are unchanged on POSIX.
xiaoyaoqilan
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 25, 2026 06:49
Contributor
Greptile SummaryThis PR makes three codebase-check whitelists portable across operating systems.
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness or security issues identified. The changes consistently convert OS-native separators in locally derived relative paths to the forward-slash format already used by the static whitelists, without changing scanned files or whitelist contents. Important Files Changed
Reviews (1): Last reviewed commit: "codebase_checks: make whitelist path mat..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3179 +/- ##
==========================================
- Coverage 73.33% 71.78% -1.56%
==========================================
Files 1038 1112 +74
Lines 94300 109849 +15549
Branches 8546 10576 +2030
==========================================
+ Hits 69154 78850 +9696
- Misses 22799 28235 +5436
- Partials 2347 2764 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 175 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WHITELIST path comparisons in
test_get_logger,test_no_sections, andtest_no_dunder_newcomparerel_pathagainst "/"-hardcoded paths. Butrel_pathis built fromos.path.relpath/Path.relative_to, which yield OS-native separators ("\" on Windows). On any OS whereos.sep != "/", the comparison never matches, so the whitelist is dead code: it masks real violations and reports spurious ones.test_no_get_loggercurrently fails on Windows with 8 false positives (the 8 whitelistedlogging.getLoggerusages all get flagged). The same latent bug affectstest_no_sections(docker_module.py sentinel) andtest_no_dunder_new(mujoco__new__).Normalize
rel_pathto forward slashes before comparing. No-op on Linux/macOS, correct everywhere. Verified: the three checks now pass on Windows and are unchanged on POSIX.