Conversation
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
crazy-max
reviewed
Sep 14, 2026
Signed-off-by: MohammadHasan Akbari <jarqvi.jarqvi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4040
The kubernetes driver dials a builder pod by running
buildctl dial-stdiothrough the exec API.
ExecConnstartedStreamWithContextin a goroutine andreturned the connection immediately, before the SPDY stream was up. If the
upgrade failed (e.g.
tls: internal erroron a fresh node whose kubelet certisn't signed yet),
Dial()had already reported success, sotryWithBackoffnever retried and the error surfaced later as a gRPC client-preface error.
Wait until the stream is established before returning. The executor reads stdin
only once its streams are created, so the first stdin read is used as the
readiness signal — no sleeps or probes. Transient setup failures are now
returned synchronously so
tryWithBackoffcan retry, and context cancellationstill unblocks the wait.
Added unit tests for
newExecConnandtryWithBackoffusing a fake executor.