Conversation
Select sticky pods with a single scan instead of constructing and sorting a hash ring. Preserve the existing hash ordering, successor semantics, and random-chooser fallback when the initial pod list is empty. Remove the hashring dependency and add compatibility fixtures covering existing assignments, exact matches, wraparound, and pod removal. Add regression coverage for the fallback succeeding, finding no pods, or returning a list error. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
github-actions
Bot
added
area/driver/kubernetes
area/driver
area/dependencies
area/tests
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
serialx/hashringdependency with a local implementation for sticky pod selection. Buildx only uses the library to construct an unweighted ring and perform one lookup, so a single scan avoids allocating and sorting the ring while preserving existing context-to-pod assignments and cache locality.The implementation retains the original hash ordering, exact-match and wraparound behavior, and random-chooser fallback when the initial pod list is empty. Compatibility was checked against the previous library across 64,000 selections, with permanent regression tests covering representative assignments, pod removal, and fallback behavior.