cli/compose: honor service profiles on stack deploy - #7300
Open
locker95 wants to merge 2 commits into
Open
Conversation
stack config currently rejects profiles as an additional property. parse the field and only enable those services when --profile or COMPOSE_PROFILES is set. Fixes docker#4721 Fixes docker#3178 Signed-off-by: Dean Chen <862469039@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker stack configcurrently dies onprofiles:withAdditional property profiles is not allowed.This accepts the field and only brings those services in when
--profileorCOMPOSE_PROFILESis set, same idea as compose.Fixes #4721
Fixes #3178