Skip to content

Remove the TODO from the slsa-provenance.md #26193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-hacker39 wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −5
Open

Remove the TODO from the slsa-provenance.md #26193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d506a81
Remove the TODO from the slsa-provenance.md
mr-hacker39 Sep 26, 2026
5e83b4e
Removed the redundant TODO from ci.md
mr-hacker39 Sep 26, 2026
f2f36d7
Fix Docker Build Cloud CI examples
mr-hacker39 Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions content/manuals/build-cloud/ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,18 +94,20 @@ If you are not an organization administrator:

### GitHub Actions

<!-- TODO: Confirm whether standard Buildx requires a minimum setup-buildx-action version. -->

```yaml
name: ci

on:
push:
branches:
- "main"
pull_request:
branches:
- "main"

jobs:
docker:
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
steps:
- name: Login to Docker Hub
Expand All @@ -129,6 +131,9 @@ jobs:
outputs: ${{ github.event_name == 'pull_request' && 'type=cacheonly' || 'type=registry' }}
```

Pull requests from forks skip this job because they don't have access to the
required secrets.

The example above uses `docker/build-push-action`, which automatically uses the
builder set up by `setup-buildx-action`. If you need to use the `docker build`
command directly instead, you have two options:
Expand Down Expand Up @@ -174,6 +179,8 @@ variables:
# Build multi-platform image and push to a registry
build_push:
stage: build
rules:
- if: '$CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
script:
- |
docker buildx build \
Expand All @@ -184,6 +191,8 @@ build_push:
# Build an image and discard the result
build_cache:
stage: build
rules:
- if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_SOURCE_PROJECT_PATH == $CI_PROJECT_PATH'
script:
- |
docker buildx build \
Expand Down Expand Up @@ -271,7 +280,7 @@ steps:
key: build-push
plugins:
- docker-login#v2.1.0:
username: DOCKER_ACCOUNT
username: "<DOCKER_ACCOUNT>" # replace with your organization name or username
password-env: DOCKER_ACCESS_TOKEN # the variable name in the environment hook
```

Expand Down
2 changes: 0 additions & 2 deletions content/manuals/build/metadata/attestations/slsa-provenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ RUN apt-get update

## Provenance attestation example

<!-- TODO: add a link to the definitions page, imported from moby/buildkit -->

The following example shows what a JSON representation of a provenance
attestation with `mode=max` looks like:

Expand Down