Skip to content

bugfix: add fix for istio on multi-cloud playground#404

Open
alaye-ms wants to merge 1 commit into
documentdb:mainfrom
alaye-ms:users/alaye/istioFix
Open

bugfix: add fix for istio on multi-cloud playground#404
alaye-ms wants to merge 1 commit into
documentdb:mainfrom
alaye-ms:users/alaye/istioFix

Conversation

@alaye-ms

Copy link
Copy Markdown
Collaborator

Upgrade istio version on the multi-cloud playground, and also add a workaround for the webhook for fleet.

Signed-off-by: Alexander Laye <alaye@microsoft.com>
Copilot AI review requested due to automatic review settings June 15, 2026 18:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the multi-cloud playground Fleet/Istio setup to improve multi-cluster deployment reliability by upgrading Istio and adjusting how Fleet placements and admission webhooks behave on the hub cluster.

Changes:

  • Upgrades the Istio tooling version used by the multi-cloud deployment script.
  • Refactors Fleet placement so the namespace is placed independently (NamespaceOnly) and app resources are placed via a namespaced ResourcePlacement.
  • Adds a hub webhook failurePolicy workaround to allow applying placement resources when the hub has no running webhook endpoints; updates base placement selectors to use labels.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
documentdb-playground/multi-cloud-deployment/documentdb-cluster.yaml Splits namespace placement (CRP) from application resource placement (RP) for Fleet.
documentdb-playground/multi-cloud-deployment/documentdb-base.yaml Switches some Fleet selectors to label-based selection and updates CNPG CRD list.
documentdb-playground/multi-cloud-deployment/deploy.sh Upgrades Istio version and adjusts istioctl installation flow.
documentdb-playground/multi-cloud-deployment/deploy-documentdb.sh Adds hub validating webhook workaround and updates placement resource names.

Comment thread documentdb-playground/multi-cloud-deployment/deploy-documentdb.sh
Comment thread documentdb-playground/multi-cloud-deployment/deploy-documentdb.sh
Comment thread documentdb-playground/multi-cloud-deployment/deploy-documentdb.sh
Comment thread documentdb-playground/multi-cloud-deployment/deploy.sh
@documentdb-triage-tool documentdb-triage-tool Bot added ecosystem enhancement New feature or request labels Jun 15, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: ecosystem, enhancement
Project fields suggested: Component playground · Priority P2 · Effort M · Status Needs Review
Confidence: 0.82 (mixed)

Reasoning

component from path globs (playground); effort from diff stats (81+31 LOC, 4 files); LLM: Fixes a broken istio configuration in the multi-cloud playground by upgrading the version and adding a webhook workaround for fleet.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecosystem enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants