Skip to content

chore: sync upstream (runner v2.337.0, sdkmanager retry) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azlekov merged 4 commits into from
Sep 2, 2026
Merged

chore: sync upstream (runner v2.337.0, sdkmanager retry) #12

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
832188d
fix: retry sdkmanager install on transient download failures
compscidr Aug 27, 2026
4eca35c
Update myoung34/github-runner Docker tag to v2.337.0 (#80)
renovate[bot] Aug 27, 2026
13ea353
Merge pull request #81 from compscidr/fix/retry-sdkmanager-install
compscidr Aug 27, 2026
07e1a77
chore: merge upstream compscidr/main (runner 2.337.0, sdkmanager retry)
azlekov Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VERSION=2.336.0-ubuntu-noble
ARG VERSION=2.337.0-ubuntu-noble
ARG JAVA_VERSION=21
ARG NODE_VERSION=24
ARG COMPILE_SDK=36.1
Expand Down Expand Up @@ -62,12 +62,24 @@ RUN ${ANDROID_ROOT}/sdk/cmdline-tools/latest/bin/sdkmanager --licenses >/dev/nul
# build-tools and NDK are backward compatible, and you only need the platform
# matching your project's compileSdk. Projects needing older platforms can install
# them at build time via sdkmanager.
RUN echo "y" | ${ANDROID_ROOT}/sdk/cmdline-tools/latest/bin/sdkmanager --sdk_root=$ANDROID_ROOT/sdk/ \
"platform-tools" \
"platforms;android-${COMPILE_SDK}" \
"build-tools;${BUILD_TOOLS}" \
"ndk;${NDK_VERSION}" \
"cmake;3.22.1"
#
# sdkmanager has no download retry: a truncated download from dl.google.com
# surfaces as "Archive is not a ZIP archive" and fails the whole build. It is
# idempotent (already-installed packages are skipped), so retry the whole
# command a few times, clearing its download scratch dir between attempts.
RUN attempt=1; \
until echo "y" | ${ANDROID_ROOT}/sdk/cmdline-tools/latest/bin/sdkmanager --sdk_root=$ANDROID_ROOT/sdk/ \
"platform-tools" \
"platforms;android-${COMPILE_SDK}" \
"build-tools;${BUILD_TOOLS}" \
"ndk;${NDK_VERSION}" \
"cmake;3.22.1"; do \
if [ "$attempt" -ge 3 ]; then echo "sdkmanager failed after $attempt attempts" >&2; exit 1; fi; \
echo "sdkmanager attempt $attempt failed, retrying in 15s..." >&2; \
rm -rf ${ANDROID_ROOT}/sdk/.temp; \
attempt=$((attempt + 1)); \
sleep 15; \
done

WORKDIR /actions-runner
ENV PATH="${PATH}:/usr/local/lib/android/sdk/platform-tools/"
Expand Down