Fix licence in homepage JSON-LD and de-duplicate the graph - #55
Open
arhimede wants to merge 1 commit into
Open
Conversation
The five SoftwareApplication nodes declared BSD-3-Clause; all five packages are MIT. They were near-identical copies, so they are now generated from one products array and the licence is set once. Also: stable @id values instead of absolute_url('/'), each app node linked to the Organization, all values through |json_encode, updated API and Light descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five
SoftwareApplicationnodes declaredBSD-3-Clause. All five packages are MIT —LICENSE.mdandcomposer.jsonin each repo, and the shields.io badges on the same page already render MIT.They were near-identical copies, which is how one wrong licence became five. Now generated from a single
productsarray.Also in this change:
@iduses a fixed canonical origin instead ofabsolute_url('/'), so entity identities survive the move offnew.dotkernel.com@id,authorandpublisherlinking it to the Organization|json_encode, so Twig autoescape can't turn an apostrophe into'inside the JSONsameAsdrops the site's own URL, adds Packagist and XVerified by rendering through Twig and
json_decode: valid JSON, 7 nodes, all licences MIT.Follow-up needed: the API and Light descriptions now differ from the visible cards in
src/App/templates/app/index.html.twig. That file also still showsBSD-3-Clausein the hero. Structured data should match on-page copy, so that template needs the same edits.