Remove platform-specific builds#4465
Merged
paulmedynski merged 8 commits intoJul 23, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
|
@edwardneal - Thanks for progressing this work! It will lead to a much more simplified repo, build system, pipelines, and NuGet package layout. I will review this eagerly :) One ask though - can you benchmark before and after these changes? I'd like to see if there is any significant change we need to be aware of. |
edwardneal
commented
Jul 21, 2026
paulmedynski
requested changes
Jul 21, 2026
paulmedynski
left a comment
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
Love it! Just one comment/question.
github-project-automation
Bot
moved this from In review
to Waiting for customer
in SqlClient Board
Contributor
Author
|
Initial benchmarks are below. All benchmarks are connecting to a locally-run SQL Server 2025 instance on Windows, with no AppContext switches set. HeaderSummary
Connection open/close
Send strings
|
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
paulmedynski
enabled auto-merge (squash)
July 22, 2026 19:14
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
==========================================
- Coverage 65.83% 62.45% -3.39%
==========================================
Files 287 283 -4
Lines 43763 66821 +23058
==========================================
+ Hits 28812 41730 +12918
- Misses 14951 25091 +10140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benrr101
approved these changes
Jul 22, 2026
benrr101
left a comment
benrr101
left a comment
Contributor
There was a problem hiding this comment.
Fantastic work, thank you so much @edwardneal !! I'm surprised it was so easy!
There's still work to do to rework the nuget package and such, but that's something I'd be happy to take on. And that next step to eliminate the ref and unsupported projects is something I've wanted to do since I joined the team a while ago 😅
edwardneal
deleted the
target-single-platforms/03-sni-and-remaining-types
branch
July 23, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows up #4207, feeding the same pattern through the SNI layer and removing the logic which sets
_UNIXand_WINDOWS. By the end of this, we've got the SqlClient project building the same code for both Windows and non-Windows platforms, but without any changes to the structure of the NuGet package.We can't move commit-by-commit and see a compiling project, but I've worked upwards from the SNI layer.
cc @benrr101
Issues
Follows up #4207.
Part of #4239.
Testing
Tests continue to pass, and I've checked the output of an application which has been trimmed. All but two types are removed as expected on Linux,
OsConstantsis folded to a constant and the managed SNI is retained.With that being said, I'm running on Windows. I'd definitely appreciate a CI run to ensure that we've got a baseline of a working NuGet package on Linux in an untrimmed configuration.