Skip to content

Move Kerberos pipeline to ci/ and rename to sqlclient-ci-kerberos-pipeline.yml#4468

Merged
paulmedynski merged 2 commits into
mainfrom
dev/paul/sqlclient-ci-kerberos
Jul 22, 2026
Merged

Move Kerberos pipeline to ci/ and rename to sqlclient-ci-kerberos-pipeline.yml#4468
paulmedynski merged 2 commits into
mainfrom
dev/paul/sqlclient-ci-kerberos

Conversation

@paulmedynski

@paulmedynski paulmedynski commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves the Kerberos test pipeline under the ci/ directory and renames the main pipeline file to follow the ci/ naming convention (matching ci/stress/sqlclient-ci-stress-pipeline.yml).

Changes

  • Moved eng/pipelines/kerberos/eng/pipelines/ci/kerberos/ (folder with all templates, via git mv to preserve history)
  • Renamed sqlclient-kerberos.ymlsqlclient-ci-kerberos-pipeline.yml
  • Updated the header comment name and template references inside the pipeline to /eng/pipelines/ci/kerberos/...
  • Updated the PR trigger path filters in sqlclient-pr-package-ref-pipeline.yml and sqlclient-pr-project-ref-pipeline.yml to remove Kerberos entirely since it is now under ci/*

Tests

…eline.yml

Move eng/pipelines/kerberos/ to eng/pipelines/ci/kerberos/ and rename the
main pipeline file to sqlclient-ci-kerberos-pipeline.yml to match the ci/
naming convention. Update template references and PR trigger path filters.
Copilot AI review requested due to automatic review settings July 22, 2026 12:53
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the Kerberos authentication CI pipeline into the standardized eng/pipelines/ci/ layout and renames the main pipeline YAML to align with existing ci/* naming conventions (e.g., ci/stress/).

Changes:

  • Relocated the Kerberos pipeline YAML and templates to eng/pipelines/ci/kerberos/, and renamed the entry YAML to sqlclient-ci-kerberos-pipeline.yml.
  • Updated template references within the Kerberos pipeline to the new /eng/pipelines/ci/kerberos/... paths and adjusted the header comment name.
  • Updated PR validation pipeline path filters to exclude changes under eng/pipelines/ci/kerberos/*.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/pipelines/sqlclient-pr-project-ref-pipeline.yml Updates PR path exclusions to reflect the new Kerberos pipeline location under ci/kerberos/.
eng/pipelines/sqlclient-pr-package-ref-pipeline.yml Same PR path exclusion update for the package-reference PR pipeline.
eng/pipelines/ci/kerberos/sqlclient-ci-kerberos-pipeline.yml Renamed/moved pipeline entry YAML and updated internal template references to the new folder structure.
eng/pipelines/ci/kerberos/linux-init-step.yml Kerberos Linux domain join + TGT acquisition template now located under ci/kerberos/.
eng/pipelines/ci/kerberos/linux-cleanup-step.yml Kerberos Linux cleanup template now located under ci/kerberos/.
eng/pipelines/ci/kerberos/build-and-test-steps.yml Shared Kerberos build/test/publish steps template now located under ci/kerberos/.

@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Jul 22, 2026
@paulmedynski paulmedynski moved this from To triage to In progress in SqlClient Board Jul 22, 2026
@paulmedynski paulmedynski added this to the 7.1.0-preview3 milestone Jul 22, 2026
Copilot AI review requested due to automatic review settings July 22, 2026 13:11
The broader eng/pipelines/ci/* exclusion already covers the kerberos
subfolder recursively.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

Comment thread eng/pipelines/sqlclient-pr-project-ref-pipeline.yml
Comment thread eng/pipelines/sqlclient-pr-package-ref-pipeline.yml
@paulmedynski paulmedynski added Hotfix 7.0.3 PRs targeting main that should be backported to release/7.0 branch for next release. Hotfix 6.1.7 PRs targeting main that should be backported to release/6.1 branch for future hotfix labels Jul 22, 2026
@paulmedynski
paulmedynski marked this pull request as ready for review July 22, 2026 18:04
@paulmedynski
paulmedynski requested a review from a team as a code owner July 22, 2026 18:04
@paulmedynski
paulmedynski enabled auto-merge (squash) July 22, 2026 18:04
@paulmedynski paulmedynski moved this from In progress to In review in SqlClient Board Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.88%. Comparing base (8e5bf00) to head (cf4bd63).

❗ There is a different number of reports uploaded between BASE (8e5bf00) and HEAD (cf4bd63). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8e5bf00) HEAD (cf4bd63)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4468      +/-   ##
==========================================
- Coverage   72.25%   64.88%   -7.38%     
==========================================
  Files         292      287       -5     
  Lines       44029    66958   +22929     
==========================================
+ Hits        31813    43444   +11631     
- Misses      12216    23514   +11298     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101 benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it's not really necessary, but sure why not

@paulmedynski
paulmedynski merged commit 188c71e into main Jul 22, 2026
313 checks passed
@paulmedynski
paulmedynski deleted the dev/paul/sqlclient-ci-kerberos branch July 22, 2026 23:55
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. Hotfix 6.1.7 PRs targeting main that should be backported to release/6.1 branch for future hotfix Hotfix 7.0.3 PRs targeting main that should be backported to release/7.0 branch for next release.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants