Skip to content

Enable nullability in benchmarks and core tests - #38788

Merged
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-1-core
Aug 12, 2026
Merged

Enable nullability in benchmarks and core tests#38788
AndriySvyryd merged 1 commit into
mainfrom
issue24427-nrt-1-core

Conversation

@AndriySvyryd

@AndriySvyryd AndriySvyryd commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part 1 of 5 for #24427.

Summary

  • Removes nullable opt-outs from benchmark and core test projects.
  • Annotates benchmark models, shared core test infrastructure, core unit tests, InMemory unit tests, and proxy tests.
  • Preserves existing assertion behavior while making optional CLR members explicit.

Stack

  1. Enable nullability in benchmarks and core tests #38788 (this PR)
  2. Enable nullability in provider tests #38789
  3. Enable nullability in relational and design tests #38790
  4. Enable nullability in shared specification tests #38791
  5. Enable nullability in shared test sources #38792

Each PR is based on the preceding stack branch and builds independently.

Validation

  • Full EFCore.slnx build at this tip: 0 warnings, 0 errors.
  • The final stack tip matches the fully validated snapshot used for all unit and functional test runs.
  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow the required format
  • Tests for the changes have been added or existing coverage validates the migration
  • Code follows the same patterns and style as existing code in this repo

@AndriySvyryd
Enable nullability in benchmarks and core tests
6f097df 
- Remove nullable opt-outs from benchmark and core test projects
- Annotate shared test infrastructure, core, InMemory, and proxy tests

Part of #24427
@AndriySvyryd
AndriySvyryd requested a review from wtgodbe as a code owner August 12, 2026 03:43
Copilot AI lite review requested due to automatic review settings August 12, 2026 03:43
@AndriySvyryd
AndriySvyryd requested a review from a team as a code owner August 12, 2026 03:43
This was referenced Aug 12, 2026
Merged
Merged
This was referenced Aug 12, 2026
Merged
Merged
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is part 1 of the #24427 stack to enable nullable reference types across EFCore benchmarks and core test projects, removing project-level nullable opt-outs and updating test/benchmark code to compile cleanly under NRT while preserving existing behavior.

Changes:

  • Removed <Nullable>disable</Nullable> from core test, provider test, and benchmark projects.
  • Added/adjusted nullability annotations and null-suppression across core tests and benchmark model types (e.g., string?, IServiceProvider?, null!, ! on reflection/lookups).
  • Refactored some test scaffolding to better satisfy NRT (e.g., helper method for method sets in ApiConsistencyTest).

Reviewed changes

Copilot reviewed 212 out of 264 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/EFCore.Tests/ValueGeneration/ValueGeneratorSelectorTest.cs Adds null-forgiving operators and initializes reference properties for NRT.
test/EFCore.Tests/ValueGeneration/ValueGeneratorCacheTest.cs Adds null-forgiving operators on model metadata lookups for NRT.
test/EFCore.Tests/ValueGeneration/TemporaryNumberValueGeneratorFactoryTest.cs Adds null-forgiving operators and initializes reference properties for NRT.
test/EFCore.Tests/ValueGeneration/StringValueGeneratorTest.cs Uses null! for generator Next argument under NRT.
test/EFCore.Tests/ValueGeneration/SequentialGuidValueGeneratorTest.cs Uses null! for generator Next argument under NRT.
test/EFCore.Tests/ValueGeneration/GuidValueGeneratorTest.cs Uses null! for generator Next argument under NRT.
test/EFCore.Tests/ValueGeneration/BinaryValueGeneratorTest.cs Uses null! for generator Next argument under NRT.
test/EFCore.Tests/Utilities/CheckTest.cs Updates test parameter nullability and null literals for NRT correctness.
test/EFCore.Tests/TestUtilities/TestInMemoryTransactionManager.cs Aligns transaction manager overrides/fields with nullable semantics.
test/EFCore.Tests/Storage/ValueConversion/ValueConverterTest.cs Adds nullability adjustments and an explicit Assert.NotNull after Find.
test/EFCore.Tests/Storage/ValueConversion/ValueConverterSelectorTest.cs Updates hint tuple and helper signatures to allow nullable hints.
test/EFCore.Tests/Storage/ValueConversion/TimeSpanConvertersTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/TimeOnlyConvertersTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToTimeSpanConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToGuidConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToEnumConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToDateTimeOffsetConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToDateTimeConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToCharConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/StringToBoolConverterTest.cs Uses null! and adds null-forgiving casts for NRT.
test/EFCore.Tests/Storage/ValueConversion/GuidToStringConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/GuidToBytesConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/EnumToStringConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/DateTimeOffsetConvertersTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/DateTimeConvertersTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/DateOnlyConvertersTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/CharToStringConverterTest.cs Uses null! for exception tests under NRT.
test/EFCore.Tests/Storage/ValueConversion/BoolToStringConverterTest.cs Uses null! in conversion tests under NRT.
test/EFCore.Tests/Storage/ExecutionStrategyTest.cs Makes delegates nullable and adds null-forgiving operators where required by NRT.
test/EFCore.Tests/SharedTypeDbSetTest.cs Initializes non-nullable reference properties for NRT.
test/EFCore.Tests/ServiceProviderCacheTest.cs Adds null-forgiving operators and makes _info nullable for NRT.
test/EFCore.Tests/Query/QueryProviderTest.cs Adds null-forgiving on non-generic Execute result and initializes DbSet for NRT.
test/EFCore.Tests/Query/Internal/NavigationExpandingExpressionVisitorTests.cs Adds null! to test-only stubs and null-forgiving on metadata creation.
test/EFCore.Tests/Query/ExpressionEqualityComparerTest.cs Adds null-forgiving on reflection lookups and initializes list properties for NRT.
test/EFCore.Tests/Metadata/Internal/PropertyListComparerTest.cs Adds null-forgiving on entity type creation.
test/EFCore.Tests/Metadata/Internal/PropertyAccessorsFactoryTest.cs Adds null-forgiving on delegate getters returned by accessors factory.
test/EFCore.Tests/Metadata/Internal/NavigationTest.cs Adds null-forgiving on metadata APIs and initializes navigation properties for NRT.
test/EFCore.Tests/Metadata/Internal/ModelTest.cs Adds null-forgiving on FullName and reflection lookups; initializes navigations.
test/EFCore.Tests/Metadata/Internal/KeyTest.cs Adds null-forgiving on convention model APIs and initializes reference properties for NRT.
test/EFCore.Tests/Metadata/Internal/InternalNavigationBuilderTest.cs Adds null-forgiving to metadata builder chaining and initializes backing fields/properties for NRT.
test/EFCore.Tests/Metadata/Internal/InternalIndexBuilderTest.cs Adds null-forgiving on builder return values and reflection lookups.
test/EFCore.Tests/Metadata/Internal/EntityTypeTest.BaseType.cs Adds null-forgiving to entity lookups and key/property operations.
test/EFCore.Tests/Metadata/Internal/CollectionTypeFactoryTest.cs Makes event handler nullable for NRT.
test/EFCore.Tests/Metadata/Internal/ClrPropertyGetterFactoryTest.cs Adjusts stub property nullability and adds null-forgiving on reflection lookups.
test/EFCore.Tests/Metadata/Conventions/ServicePropertyDiscoveryConventionTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/Metadata/Conventions/QueryFilterRewritingConventionTest.cs Adds null-forgiving on builder calls; initializes navigation property for NRT.
test/EFCore.Tests/Metadata/Conventions/PropertyDiscoveryConventionTest.cs Initializes private field and reference properties; adds null-forgiving on metadata lookups.
test/EFCore.Tests/Metadata/Conventions/PrimaryKeyAttributeConventionTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/Metadata/Conventions/NonNullableNavigationConventionTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/Metadata/Conventions/ModelCleanupConventionTest.cs Adds null-forgiving on builder APIs; initializes navigations for NRT.
test/EFCore.Tests/Metadata/Conventions/KeyDiscoveryConventionTest.cs Adds null-forgiving on builder APIs and on primary key lookup.
test/EFCore.Tests/Metadata/Conventions/IndexAttributeConventionTest.cs Adds null-forgiving on builder APIs and attribute argument to satisfy NRT.
test/EFCore.Tests/Metadata/Conventions/ForeignKeyIndexConventionTest.cs Adds null-forgiving on metadata lookups; initializes navigation for NRT.
test/EFCore.Tests/Metadata/Conventions/EntityTypeConfigurationAttributeConventionTest.cs Adds null-forgiving on model lookups; initializes reference properties for NRT.
test/EFCore.Tests/Metadata/Conventions/EntityTypeAttributeConventionTest.cs Adds null-forgiving on builder APIs; initializes navigations for NRT.
test/EFCore.Tests/Metadata/Conventions/DerivedTypeDiscoveryConventionTest.cs Adds null-forgiving on builder APIs.
test/EFCore.Tests/Metadata/Conventions/ConventionSetBuilderTests.cs Initializes reference property for NRT.
test/EFCore.Tests/Metadata/Conventions/ConstructorBindingConventionTest.cs Adds null-forgiving on reflection lookups and metadata property lookups; initializes fields/properties for NRT.
test/EFCore.Tests/Metadata/Conventions/CascadeDeleteConventionTest.cs Initializes navigation/collection properties for NRT.
test/EFCore.Tests/Metadata/Conventions/BaseTypeDiscoveryConventionTest.cs Adds null-forgiving on builder APIs.
test/EFCore.Tests/Infrastructure/StructuredJsonPathTest.cs Adds null-forgiving when asserting on nullable Indices property.
test/EFCore.Tests/Infrastructure/ServiceCollectionMapTest.cs Initializes injected Context property and null-forgives service resolution.
test/EFCore.Tests/Infrastructure/ModelValidatorTest.PropertyMapping.cs Initializes reference properties and adjusts nullability for optional properties.
test/EFCore.Tests/Infrastructure/ModelSourceTest.cs Initializes DbSet properties and null-forgives reflection attribute value.
test/EFCore.Tests/Infrastructure/InternalServiceCollectionMapTest.cs Null-forgives null-returning delegate and service resolutions; initializes injected properties.
test/EFCore.Tests/Infrastructure/Internal/ConcurrencyDetectorTest.cs Adjusts nullability of lazy loader/customer backing field and navigation access.
test/EFCore.Tests/Infrastructure/EventIdTestBase.cs Makes optional parameters nullable and adjusts reflection/args array nullability for NRT.
test/EFCore.Tests/Infrastructure/EntityFrameworkMetricsTest.cs Null-forgives Find and initializes DbSet for NRT.
test/EFCore.Tests/Infrastructure/DbSetFinderTest.cs Initializes DbSet and other reference properties; uses null! for non-instantiated sets.
test/EFCore.Tests/Infrastructure/DatabaseFacadeTest.cs Updates enlistment nullability to align with new nullable signatures.
test/EFCore.Tests/Infrastructure/AnnotatableTest.cs Null-forgives annotation lookup results for NRT.
test/EFCore.Tests/IEntityTypeConfigurationTest.cs Null-forgives model/property lookups; initializes navigations/collections for NRT.
test/EFCore.Tests/Extensions/PropertyInfoExtensionsTest.cs Null-forgives reflection property lookups used in assertions.
test/EFCore.Tests/Extensions/ExpressionExtensionsTest.cs Initializes reference properties in nested test types for NRT.
test/EFCore.Tests/ExceptionTest.cs Adjusts stub signatures/props for nullable values and null-forgives entity type lookup.
test/EFCore.Tests/EFCore.Tests.csproj Removes <Nullable>disable</Nullable> to enable NRT.
test/EFCore.Tests/Diagnostics/CoreEventIdTest.cs Null-forgives reflection/model building and updates service provider signature for NRT.
test/EFCore.Tests/DbSetTest.cs Initializes DbSet properties for NRT.
test/EFCore.Tests/DbSetInitializerTest.cs Null-forgives reflection results and initializes DbSet properties for NRT.
test/EFCore.Tests/DbContextTest.Tracking.cs Initializes navigation properties for NRT.
test/EFCore.Tests/DbContextLoggerTests.cs Null-forgives product version and ToString() result for NRT.
test/EFCore.Tests/CollectionComparerTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/TemporaryValuesTest.cs Initializes reference property and uses default! in indexers to satisfy NRT.
test/EFCore.Tests/ChangeTracking/SkipNavigationEntryTest.cs Adds null-forgiving on CurrentValue casts for NRT.
test/EFCore.Tests/ChangeTracking/SkipMemberEntryTest.cs Adds null-forgiving on CurrentValue casts and metadata lookups for NRT.
test/EFCore.Tests/ChangeTracking/ReferenceEntryTest.cs Null-forgives TargetEntry dereferences and initializes navigation/DbSet for NRT.
test/EFCore.Tests/ChangeTracking/PropertyEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/ObservableHashSetTest.cs Adds null-forgiving on NotifyCollectionChangedEventArgs collections and sender nullability.
test/EFCore.Tests/ChangeTracking/NavigationEntryTest.cs Initializes navigation and DbSet properties for NRT.
test/EFCore.Tests/ChangeTracking/MemberEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/Internal/SortableBindingListTest.cs Initializes reference properties and adjusts comparer signature for NRT.
test/EFCore.Tests/ChangeTracking/Internal/ShadowFkFixupTest.cs Initializes navigation properties for NRT.
test/EFCore.Tests/ChangeTracking/Internal/ShadowFixupTest.cs Null-forgives primary key lookups for NRT.
test/EFCore.Tests/ChangeTracking/Internal/PropertyValuesTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/Internal/ObservableBackedBindingListTest.cs Initializes reference properties and null-forgives property descriptor lookup for NRT.
test/EFCore.Tests/ChangeTracking/Internal/KeyPropagatorTest.cs Null-forgives metadata lookups and initializes navigations for NRT.
test/EFCore.Tests/ChangeTracking/Internal/InternalMixedEntityEntryTest.cs Initializes navigation properties in test types for NRT.
test/EFCore.Tests/ChangeTracking/Internal/InternalEntityEntryFactoryTest.cs Initializes reference property for NRT.
test/EFCore.Tests/ChangeTracking/Internal/InternalComplexEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/Internal/FixupCompositeTest.cs Initializes navigation properties for NRT.
test/EFCore.Tests/ChangeTracking/GraphTrackingTest.cs Initializes DbSets and navigation properties for NRT.
test/EFCore.Tests/ChangeTracking/FindEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/EntityEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/ComplexPropertyEntryTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ChangeTracking/CollectionEntryTest.cs Null-forgives FindEntry results and initializes navigations/DbSet for NRT.
test/EFCore.Tests/ChangeTracking/ChangeTrackerTest.cs Removes file-level #nullable enable (project now enables nullable).
test/EFCore.Tests/ApiConsistencyTest.cs Refactors metadata type mapping and consolidates method sets for NRT friendliness.
test/EFCore.Proxies.Tests/TestUtilities/TestContext.cs Makes optional dbName nullable in test context base.
test/EFCore.Proxies.Tests/ProxyTests.cs Updates optional context parameters and navigation nullability; initializes DbSet for NRT.
test/EFCore.Proxies.Tests/LazyLoadingProxyTests.cs Null-forgives service resolution and updates entity nav/property nullability for NRT.
test/EFCore.Proxies.Tests/EFCore.Proxies.Tests.csproj Removes <Nullable>disable</Nullable> to enable NRT.
test/EFCore.Proxies.Tests/ChangeDetectionProxyTests.cs Null-forgives metadata lookups, updates nullable event args/senders, and entity nullability for NRT.
test/EFCore.InMemory.Tests/ValueGeneration/InMemoryValueGeneratorSelectorTest.cs Adds null-forgiving on metadata lookups and generator results; initializes reference properties.
test/EFCore.InMemory.Tests/ValueGeneration/InMemoryIntegerValueGeneratorTest.cs Uses null! for generator Next argument under NRT.
test/EFCore.InMemory.Tests/Storage/InMemoryDatabaseTest.cs Initializes reference property for NRT.
test/EFCore.InMemory.Tests/Storage/InMemoryDatabaseCreatorTest.cs Initializes DbSet and entity reference properties for NRT.
test/EFCore.InMemory.Tests/EFCore.InMemory.Tests.csproj Removes <Nullable>disable</Nullable> to enable NRT.
benchmark/EFCore.SqlServer.Benchmarks/Support/SqlServerBenchmarkEnvironment.cs Makes optional parameters nullable for NRT.
benchmark/EFCore.SqlServer.Benchmarks/Models/Orders/OrdersSqlServerFixture.cs Makes optional IServiceProvider nullable for NRT.
benchmark/EFCore.SqlServer.Benchmarks/Models/Orders/OrdersSqlServerContext.cs Makes optional IServiceProvider nullable for NRT.
benchmark/EFCore.SqlServer.Benchmarks/EFCore.SqlServer.Benchmarks.csproj Removes <Nullable>disable</Nullable> to enable NRT.
benchmark/EFCore.Sqlite.Benchmarks/Models/Orders/OrdersSqliteFixture.cs Null-forgives GetDirectoryName and makes optional IServiceProvider nullable for NRT.
benchmark/EFCore.Sqlite.Benchmarks/Models/Orders/OrdersSqliteContext.cs Makes optional IServiceProvider nullable for NRT.
benchmark/EFCore.Sqlite.Benchmarks/Models/AdventureWorks/AdventureWorksSqliteFixture.cs Null-forgives GetDirectoryName for NRT.
benchmark/EFCore.Sqlite.Benchmarks/EFCore.Sqlite.Benchmarks.csproj Removes <Nullable>disable</Nullable> to enable NRT.
benchmark/EFCore.Benchmarks/UpdatePipeline/SimpleUpdatePipelineTests.cs Initializes fields to satisfy NRT.
benchmark/EFCore.Benchmarks/Query/SimpleQueryTests.cs Initializes context field to satisfy NRT.
benchmark/EFCore.Benchmarks/Query/RawSqlQueryTests.cs Initializes context field to satisfy NRT.
benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs Initializes fields and updates DTO/nullability and cache interfaces for NRT.
benchmark/EFCore.Benchmarks/Query/NavigationsQueryTests.cs Initializes fields and null-forgives optional navigation access for NRT.
benchmark/EFCore.Benchmarks/Query/FuncletizationTests.cs Initializes context field to satisfy NRT.
benchmark/EFCore.Benchmarks/Models/Orders/Product.cs Makes string properties nullable and initializes collection navigation for NRT.
benchmark/EFCore.Benchmarks/Models/Orders/OrdersFixtureBase.cs Makes service provider/seed delegate nullable and updates signatures for NRT.
benchmark/EFCore.Benchmarks/Models/Orders/OrdersContextBase.cs Makes constructor IServiceProvider nullable and initializes DbSets for NRT.
benchmark/EFCore.Benchmarks/Models/Orders/OrderLine.cs Makes optional string nullable; initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/Orders/Order.cs Makes optional strings nullable; initializes navigations/collections for NRT.
benchmark/EFCore.Benchmarks/Models/Orders/Customer.cs Makes many string properties nullable; initializes collection navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/WorkOrderRouting.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/WorkOrder.cs Initializes required navigation and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Vendor.cs Initializes required reference properties and adjusts optional string nullability for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/UnitMeasure.cs Initializes required reference properties for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/TransactionHistoryArchive.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/TransactionHistory.cs Initializes required string/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Store.cs Initializes required string/navigation and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/StateProvince.cs Initializes required strings/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SpecialOfferProduct.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SpecialOffer.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ShoppingCartItem.cs Initializes required string/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ShipMethod.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Shift.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ScrapReason.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesTerritoryHistory.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesTerritory.cs Initializes required strings/navigation and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesTaxRate.cs Initializes required string/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesReason.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesPersonQuotaHistory.cs Initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesPerson.cs Initializes required navigation and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesOrderHeaderSalesReason.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesOrderHeader.cs Makes optional strings/navigations nullable and initializes required navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/SalesOrderDetail.cs Makes optional string nullable and initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/PurchaseOrderHeader.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/PurchaseOrderDetail.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductVendor.cs Initializes required string/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductSubcategory.cs Initializes required string/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductReview.cs Makes optional string nullable and initializes required strings/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductProductPhoto.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductPhoto.cs Makes byte arrays and related filenames nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductModelProductDescriptionCulture.cs Initializes required string/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductModelIllustration.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductModel.cs Initializes required string and makes optional strings nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductListPriceHistory.cs Initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductInventory.cs Initializes required string/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductDocument.cs Initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductDescription.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductCostHistory.cs Initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ProductCategory.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Product.cs Makes many strings/navigations nullable and initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/PhoneNumberType.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/PersonPhone.cs Initializes required string/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/PersonCreditCard.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Person.cs Initializes required strings/navigation and makes optional strings/navigations nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Password.cs Initializes required strings/navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Location.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/JobCandidate.cs Makes optional string and navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Illustration.cs Makes optional string nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/EmployeePayHistory.cs Initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/EmployeeDepartmentHistory.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Employee.cs Initializes required strings/navigation and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/EmailAddress.cs Makes optional string nullable and initializes navigation for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Department.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Customer.cs Initializes required string and makes optional navigations nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/CurrencyRate.cs Initializes required strings/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Currency.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Culture.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/CreditCard.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/CountryRegionCurrency.cs Initializes required strings/navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/CountryRegion.cs Initializes required strings for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/ContactType.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/BusinessEntityContact.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/BusinessEntityAddress.cs Initializes navigations for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/BusinessEntity.cs Makes optional navigations nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/BillOfMaterials.cs Initializes required string/navigations and makes optional navigation nullable for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/AddressType.cs Initializes required string for NRT.
benchmark/EFCore.Benchmarks/Models/AdventureWorks/Address.cs Initializes required strings/navigation and makes optional string nullable for NRT.
benchmark/EFCore.Benchmarks/Initialization/InitializationTests.cs Initializes service provider fields and null-forgives DI service resolution for NRT.
benchmark/EFCore.Benchmarks/EFCoreBenchmarkRunner.cs Makes optional config nullable for NRT.
benchmark/EFCore.Benchmarks/EFCore.Benchmarks.csproj Removes <Nullable>disable</Nullable> to enable NRT.
benchmark/EFCore.Benchmarks/ChangeTracker/FixupTests.cs Initializes fields to satisfy NRT.
benchmark/EFCore.Benchmarks/ChangeTracker/DbSetOperationTests.cs Initializes fields to satisfy NRT.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/EFCore.Tests/ChangeTracking/SkipNavigationEntryTest.cs
Comment thread test/EFCore.Tests/ChangeTracking/SkipMemberEntryTest.cs
@AndriySvyryd
AndriySvyryd merged commit 3f8b9c7 into main Aug 12, 2026
18 checks passed
@AndriySvyryd
AndriySvyryd deleted the issue24427-nrt-1-core branch August 12, 2026 21:25
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Aug 13, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@cincuranet cincuranet cincuranet approved these changes
@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@AndriySvyryd @cincuranet