Fix IsTableExcludedFromMigrations default for entity splitting. - #38802
Open
AndriySvyryd wants to merge 1 commit into
Open
Fix IsTableExcludedFromMigrations default for entity splitting.#38802AndriySvyryd wants to merge 1 commit into
AndriySvyryd wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the default ExcludeFromMigrations behavior for entity-splitting mapping fragments so that a split table does not implicitly inherit the main table’s excluded-from-migrations setting unless it was explicitly configured on that fragment. This aligns migration diffing behavior with the per-table nature of entity splitting.
Changes:
- Update
RelationalEntityTypeExtensions.IsTableExcludedFromMigrations(entityType, storeObject)so mapping fragments default tofalsewhen no explicit exclusion is configured. - Add a regression test ensuring that removing entity splitting still produces
DropTable/CreateTableoperations for the split table even when the main table is excluded from migrations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/EFCore.Relational.Tests/Migrations/Internal/MigrationsModelDifferTest.cs | Adds a regression test covering entity splitting removal when the main table is excluded from migrations. |
| src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs | Fixes mapping-fragment exclusion default to avoid inheriting the entity’s main table exclusion. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38780