[wasm] Rename confusing fromMonoPackage variable in AssetsComputingHelper.cs - #132205
Open
akoeplinger wants to merge 1 commit into
Open
[wasm] Rename confusing fromMonoPackage variable in AssetsComputingHelper.cs#132205akoeplinger wants to merge 1 commit into
akoeplinger wants to merge 1 commit into
Conversation
…lper.cs IsFromRuntimePack now also checks for CoreCLR runtime packs so the variable name was quite confusing.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves readability in the WebAssembly pack tasks by renaming a local boolean in AssetsComputingHelper.ShouldFilterCandidate so it accurately reflects that IsFromRuntimePack covers both Mono and CoreCLR runtime packs.
Changes:
- Rename the local flag from
fromMonoPackagetofromRuntimePack. - Update all switch guards to use the renamed flag.
Suppressed comments (1)
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs:75
- Same grammatical issue in these reason strings ("extension is .rsp is not supported" / ".props"). Rephrasing improves readability of the filtering diagnostics.
".rsp" when fromRuntimePack => "extension is .rsp is not supported.",
".props" when fromRuntimePack => "extension is .props is not supported.",
akoeplinger
enabled auto-merge (squash)
August 12, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsFromRuntimePack now also checks for CoreCLR runtime packs so the variable name was quite confusing.