Add --output=json support to ls command#270
Merged
Merged
Conversation
Refactor ls to separate entry preparation from rendering. JSON output emits an entries array with structured metadata. Deleted entries use a boolean field instead of <<>> text decoration. Also fix outputJSONRequested to use last-flag-wins semantics matching Cobra behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lsto separate entry preparation from rendering, enabling both text and JSON output from the same data{"input": {...}, "entries": [...]}with structured metadata per entry"deleted": trueinstead of<<...>>text decoration in JSONcmd.OutOrStdout()instead of rawos.StdoutoutputJSONRequestedto use last-flag-wins semantics matching Cobra behaviorTest plan
go vet ./...cleangolangci-lint run ./...cleango test ./... -count=1)dbxcli ls --output=json /emits JSON entries arraydbxcli ls -l --output=json /includes input flags in JSONdbxcli ls -d --output=json /shows deleted entries withdeleted: truedbxcli ls /text output unchanged