Skip to content

style: collapse verbose string building in pre-existing classes#1412

Merged
joaodinissf merged 1 commit into
dsldevkit:masterfrom
joaodinissf:style/pre-existing-java-tidy-ups
Jun 15, 2026
Merged

style: collapse verbose string building in pre-existing classes#1412
joaodinissf merged 1 commit into
dsldevkit:masterfrom
joaodinissf:style/pre-existing-java-tidy-ups

Conversation

@joaodinissf

Copy link
Copy Markdown
Collaborator

Behavior-identical readability tidy-ups across 14 pre-existing Java classes — mostly collapsing StringBuilder chains in toString() methods into plain concatenation or formatted strings, folding manual join loops into joins, and dropping redundant boolean field initializers and length checks. No logic changes anywhere.

These changes were flagged in #1274 review as unrelated to the Xtend migration (correctly so) and are proposed here on their own so they can be judged on their own merits.

Verified with a full mvn verify including Checkstyle and PMD: clean.

🤖 Generated with Claude Code

Behavior-identical readability tidy-ups: StringBuilder chains become plain
concatenation or formatted strings, manual join loops become joins, redundant
field initializers and length checks are dropped. No logic changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@joaodinissf joaodinissf marked this pull request as ready for review June 12, 2026 18:49
@joaodinissf joaodinissf requested a review from rubenporras June 12, 2026 18:49
@joaodinissf joaodinissf enabled auto-merge (rebase) June 12, 2026 18:49
@joaodinissf joaodinissf merged commit 59101d9 into dsldevkit:master Jun 15, 2026
4 checks passed
@joaodinissf joaodinissf deleted the style/pre-existing-java-tidy-ups branch June 15, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants