refactor: migrate Xtend to Java - com.avaloq.tools.ddk.xtext.check.generator#1426
Open
joaodinissf wants to merge 1 commit into
Open
Conversation
rubenporras
requested changes
Jun 17, 2026
…nerator Convert the module's two remaining Xtend generator fragments to hand-written Java, byte-faithful to the xtend-gen ground truth: CheckValidatorFragment2 and quickfix/CheckQuickfixProviderFragment2 (StringConcatenation(Client) templates preserved exactly, bracketed with CHECKSTYLE:CONSTANTS-OFF/ON). Remove the now-unused per-module Xtend build wiring (xtend-gen entry in build.properties/.classpath, xtextBuilder/xtextNature in .project, the xtend-gen directory). Require-Bundle is unchanged: the templates legitimately use org.eclipse.xtend2.lib, provided transitively via org.eclipse.xtext(.xtext.generator). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joaodinissf
force-pushed
the
migrate/xtend-to-java/xtext-check-generator
branch
from
4a74af4 to
d66599e
Compare
joaodinissf
added a commit
to joaodinissf/dsl-devkit
that referenced
this pull request
Jun 17, 2026
…attingTest Replace the 5 StringConcatenation builders (input/expected formatted-Check sources) with Java text blocks. Each was proven byte-identical to the original StringConcatenation output via a comparator before applying, so the formatter assertions are unchanged. Drops the org.eclipse.xtend2.lib.StringConcatenation dependency from this test (file shrinks ~1018->570 lines). Addresses Ruben's review preference (cf. dsldevkit#1426). CheckModelUtil's StringBuilder is a genuine for-loop over a List and is correctly left as idiomatic java.lang.StringBuilder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the
com.avaloq.tools.ddk.xtext.check.generatormodule's two remaining Xtend generator fragments to hand-written Java, leaving the module Xtend-free.Changes
CheckValidatorFragment2andquickfix/CheckQuickfixProviderFragment2converted to Java, byte-faithful to the generatedxtend-genoutput. The twoStringConcatenation/StringConcatenationClientcode-generation templates are preserved exactly and bracketed withCHECKSTYLE:CONSTANTS-OFF/ON.xtend-gensource entry inbuild.properties/.classpath,xtextBuilder/xtextNaturein.project, and thextend-gendirectory.Require-Bundleis unchanged: the generator templates legitimately useorg.eclipse.xtend2.lib, which is provided transitively viaorg.eclipse.xtext/org.eclipse.xtext.xtext.generator— there was never anxbase.lib/xtend.libentry to drop.Validation
Local
clean verify checkstyle:check pmd:check pmd:cpd-check spotbugs:checkis green (0 checkstyle / 0 PMD / 0 SpotBugs).