Reduce the 1.7 tab to a single 1.7 Animations mod - #28
Open
dsnsgithub wants to merge 3 commits into
Open
Conversation
The 1.7 features now live as one mod tile under Mods, with only the groups that are still wanted: blocking/item using, items (sprite rendering and item positions included), offsets/eye height, and sneaking. Every other 1.7 group is gone along with the code, mixins, assets and translations behind it, so the menu is down to three tabs: HUD, Mods and Settings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S3hUZRU7sMz9P9Uzub4xrU
The mod tile now carries an enabled switch, and isEnabled() reads it, so switching the mod off leaves 1.8.9 untouched: every feature already goes through that check. Two places did not, and now do — the witch held-item translation cancel is tied to Third Person Item Positions like the rest of that layer's transforms, and the water/lava/fire block items that 14w25a removed are no longer re-registered, since the models backing them went away with the rest of the 1.7 model features. The resource-reload bookkeeping tracks the effective value of Trapdoor Item Position and Jump Boost Potion Color, so flipping the master switch rebakes the trapdoor model and the potion colour cache too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S3hUZRU7sMz9P9Uzub4xrU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.7 tab is gone. Its features now live as a single, toggleable 1.7 Animations tile in the Mods tab, keeping only the wanted groups; everything else is removed along with the code behind it.
What's kept
Master toggle
The mod has its own
enabledswitch on the tile, andOldAnimationsConfig.isEnabled()reads it instead of returning a constanttrue. Every feature already went through that check, so switching the mod off leaves 1.8.9 untouched while the individual options keep their values. Two places did not go through it, and now do:Resource-reload bookkeeping tracks the effective value of Trapdoor Item Position and Jump Boost Potion Color, so flipping the master switch rebakes the trapdoor model and the potion colour cache too.
What's removed
Resources, Models, Textures, Sounds, Particles, Combat, GUI, Debug Overlay, Tab Overlay, Enchantment Glint and Hitbox — 82 options in total, plus the mixins, helper classes, assets and translations that existed only for them:
ModelBakeryMixintrimmed to the trapdoor item variant the kept Trapdoor Item Position option needs, and the mixed-purpose mixins (ItemRendererMixin,MinecraftMixin,GameRendererMixin,EntityRendererMixin,EntityRenderDispatcherMixin,LivingEntityRendererMixin,ClientPlayNetworkHandlerMixin,ItemEntityRendererMixin,ItemModelShaperMixin,WornSkullLayerMixin) stripped to their surviving features.oldanimations.mixins.jsonregenerated (88 → 31 entries) and the now-deadAmbientOcclusionFaceaccess widener entry dropped.Menu
MenuCatalog.Tab.ANIMATIONSis gone, so the menu is HUD / Mods / Settings (tab row narrowed to 3 columns), and the mod is named "1.7 Animations" with its groups rendered as inline sections.Verification
./gradlew :1.8.9:buildpasses (compile, license headers, access widener validation). The dev client was launched headless and the menu walked through in game: three tabs, one 1.7 Animations tile with a working toggle (flipping it triggers the resource rebake and persists as"enabled": "false"), and all four sections present with their options. Every remaining injector was audited for theisEnabled()guard; the only ones without it capture render state, register the trapdoor model variant, or refresh the potion cache — none change vanilla behaviour.