Skip to content

fix: avoid HTTP probes on gRPC worker groups - #4241

Closed
mikemikimike wants to merge 1 commit into
dstackai:masterfrom
mikemikimike:mikemikimike/fix/grpc-worker-readiness-probe
Closed

fix: avoid HTTP probes on gRPC worker groups#4241
mikemikimike wants to merge 1 commit into
dstackai:masterfrom
mikemikimike:mikemikimike/fix/grpc-worker-readiness-probe

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • avoid generating the model-based HTTP probe for non-router replica groups
  • keep the default probe for router groups and preserve explicitly configured probes
  • add a regression test for router/worker probe selection

Tests

  • uv run pytest src/tests/_internal/server/services/jobs/configurators/test_service.py::test_default_probe_only_for_router_replica_group -q
  • uv run pytest src/tests -q (354 passed, 4891 skipped)
  • uv run ruff check .
  • uv run ruff format --check .
  • uv run pyright -p .
  • git diff --check

Signed-off-by: mikemikimike <13286568797@163.com>
@r4victor r4victor closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants