Skip to content

Replace stmt_length with query #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smvv wants to merge 1 commit into from
+3 −5
Closed

Replace stmt_length with query #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/pystatement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ unique_ptr<SQLStatement> DuckDBPyStatement::GetStatement() {
}

string DuckDBPyStatement::Query() const {
auto &loc = statement->stmt_location;
auto &length = statement->stmt_length;
return statement->query.substr(loc, length);
return statement->query;
}

nb::set DuckDBPyStatement::NamedParameters() const {
Expand Down
4 changes: 2 additions & 2 deletions tests/fast/api/test_duckdb_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,12 @@ def test_pystatement(self):

statements = duckdb.extract_statements("select $1; select 21")
assert len(statements) == 2
assert statements[0].query.startswith("select $1")
assert statements[0].query == "select $1; "
assert statements[0].type == duckdb.StatementType.SELECT
assert statements[0].named_parameters == set("1")
assert statements[0].expected_result_type == [duckdb.ExpectedResultType.QUERY_RESULT]

assert statements[1].query.startswith("select 21")
assert statements[1].query == "select 21"
assert statements[1].type == duckdb.StatementType.SELECT
assert statements[1].named_parameters == set()

Expand Down
Loading