docs(intent): the assistant guide documents the notify fan-out (forEach) - #6445
Merged
Conversation
The notify fan-out shipped with #6435 - NotificationIntent.forEach, NotifySupport .fanOut, the glue keys, Send.java.template's per-row loop and thirteen unit cases are all on master - but the authoring guide never got its section: no "fan-out", no forEach row in the keyword table. The only forEach the guide describes is the unrelated generates/children collection (`forEach: { entity: … }`), so an assistant reading the guide cannot author the keyword the engine accepts, and would plausibly try the map shape, which a notify block does not take. The text was written when the feature was built and never left a working tree. It documents the shape (`forEach: <Entity>`, every path then resolving against the ROW - recipient, {placeholders} and the row's own attach: print), the exactly-one-back- relation rule, and why a fan-out is fail-soft per row rather than failing the step: a retry would re-mail everyone already served, so a partial send cannot be idempotent. Each claim was checked against master rather than trusted: the plain-string forEach in NotificationIntent, the exactly-ONE rule in IntentParser.validateNotifyBlock (unknown entity and zero-or-ambiguous back-reference both reported), the sent / no-recipient / failed counters and the summary log in Send.java.template, and attach: print re-pointing at the row entity. Docs only - no code, no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notify fan-out shipped with #6435 —
NotificationIntent.forEach,NotifySupport.fanOut, theforEach*glue keys,Send.java.template's per-row loop and thirteenGlueSendDocumentTestcases are all on master — but the authoring guide never got its section.On master,
intent-assistant-guide.mdhas no mention of it: no "fan-out", no "one message per related row", and the keyword table listsnotify attachwhile omittingnotify forEach. The onlyforEachthe guide describes is the unrelatedgenerates/childrencollection (forEach: { entity: … }/forEach: { days: … }).That matters more than a normal doc gap: this guide is the resource fed to the Intent Editor's AI assistant, so the assistant cannot author a keyword the engine already accepts — and would plausibly reach for the
generates-style map shape, which a notify block does not take.The text was written when the feature was built and never left a working tree.
What it documents
forEach: <Entity>, after which every path resolves against the row: the recipient, the{placeholders}, andattach: print(the row's own document);Verified against master, not trusted
Every claim was checked before writing it down:
forEach: <Entity>is a plain stringNotificationIntent.forEachIntentParser.validateNotifyBlock— unknown entity, andbackReferencesTo(...) != 1Send.java.template—sent/skipped/failedcounters + summary logattach: printrenders the row's documentvalidateNotifyBlockre-pointsaboutEntityat the row entityDocs only — no code, no behaviour change.
🤖 Generated with Claude Code