refactor(resources): rename the "My Work" shell to "Personal" (#6611) - #6612
Merged
Conversation
Every other shell on platform-shells carries a single-word label - Applications, Partner, Administration, Workbench, Dashboard - so the personal one becomes "Personal" and its module, served folder, shell id and navigation group follow the same word: resources-my -> resources-personal dirigible-components-resources-my -> ...-resources-personal /services/web/my/ -> /services/web/personal/ myShell -> personalShell group id 'my' / "My Work" -> 'personal' / "Personal" The navigation group and the groupId that the Harmonia template stamps into every generated personal perspective move in lockstep: a perspective whose groupId matches no group definer is silently dropped by the perspectives service, so the two halves can never be renamed apart. Cross-module callers updated with it: the Applications shell's act-as redirect, the Home page's icon/description fallback maps (keyed by shell id, a stale key degrades silently to a generic icon and no description) and its prose, and the IntentEmissionCoverageIT assertions on the shell URL. The shell title now resolves through a real i18n key - shell.nav.personal, added to the en-US and bg-BG application-core catalogs; the previous shell.nav.myWork never existed and always fell through to its literal. Unchanged on purpose: the extension point application-personal-perspectives is already named "personal", and the generated app's own personal routes (#/my/<Entity>), its views/my/ + pages/my/ folders and its "My <Entity>" page titles stay - "My Claims" is the right label for a per-user page inside an app. Verified on a running instance: /services/web/personal/index.html serves the shell titled "Personal", the old /my/ path 404s, platform-shells lists personalShell/"Personal" alongside the other single-word shells, and the personal perspective group resolves as id 'personal'. IntentEmissionCoverageIT (generate -> publish -> shell aggregates the personal perspective) is green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
# Conflicts: # components/pom.xml
# Conflicts: # components/resources/resources-home/src/main/resources/META-INF/dirigible/home/js/home.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6611. Every shell on
platform-shellsnow carries a single-word label.components/resources/resources-mycomponents/resources/resources-personaldirigible-components-resources-mydirigible-components-resources-personal/services/web/my//services/web/personal/myShellpersonalShellMy WorkPersonalid: 'my'/My Workid: 'personal'/PersonalThe nav group and the
groupIdthe Harmonia template stamps into every generated personal perspective (ui/my/my-perspective.js.template) move in lockstep — a perspective whosegroupIdmatches no group definer is silently dropped by the perspectives service.Callers that had to move with it: the Applications shell's act-as redirect (
resources-application/.../appShell.js), the Home page'sICONS/DESCRIPTIONSfallback maps (keyed by shell id — a stale key degrades silently to a generic icon and an empty description) and its prose, andIntentEmissionCoverageIT's shell-URL assertion.The shell title now resolves through a real key —
shell.nav.personal, added to theen-USandbg-BGapplication-corecatalogs. The previousshell.nav.myWorkdid not exist in either catalog and always fell through to its literal. The renamed group config also gains the EPL header its siblings carry (it had none).Unchanged on purpose: the extension point
application-personal-perspectivesis already named "personal"; and the generated app's own personal routes (#/my/<Entity>), itsviews/my/+pages/my/folders and its "My <Entity>" page titles stay — "My Claims" is the right label for a per-user page inside an app, and renaming those would ripple through the shell template and ~20 emission-IT assertions for no user-visible gain.Verification
On a running instance built from this branch:
IntentEmissionCoverageITgreen (intent generate → publish → the shell page is served and aggregates the published personal perspective), reactor-P quick-buildgreen,mvn -T 1C formatter:validateclean.🤖 Generated with Claude Code