feat(shells): switch shells from the user menu, and unregister the legacy Dashboard - #6616
Merged
Conversation
…gacy Dashboard Three related fixes to how the shells are reached. **A switcher in every Harmonia shell's user menu.** Under the user icon, below the account tile: Home plus every other registered shell, one click away. The list is the same `platform-shells` aggregation the Home launchpad renders - read by a new shared `shells` store - so a stack that contributes a shell gets it in the switcher for free, and each shell leaves itself out of its own list. The markup is a dozen lines per shell because each shell owns its own chrome; the logic is in application-core, once. **The legacy Dashboard shell is no longer registered.** It was superseded by the Harmonia shells and Home already hid it, but the IDE's Window > Shells menu listed it anyway - an entry nobody wanted, offering the AngularJS/BlimpKit dashboard as a peer of the shells that replaced it. Removing its `platform-shells` extension takes it out of both surfaces at once; the module stays, because the generated views still load its services. With nothing left to hide, Home's exclusion list becomes empty. **The Window menu could not see any of this.** `menus.js` and `shells.js` answered `public, must-revalidate, max-age=30 days` with a random-UUID ETag, so a browser served a month-old menu without asking - and the random ETag could never validate even when it did. That is why the "My Work" -> "Personal" rename never appeared in an open IDE, and why a newly published shell seemed to be missing. Both now answer `private, no-cache`, like the projections service: this is content that changes whenever an artefact is published, not a static asset. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related fixes to how the shells are reached.
1. A shell switcher under the user icon
Every Harmonia shell's user menu now carries Home plus every other registered shell, so switching no longer means a detour through the launchpad:
The list comes from the same
platform-shellsaggregation Home renders, read by a new sharedapplication-core/shell/js/stores/shells.js— so a stack that contributes a shell gets it in the switcher for free, with no second registration, and each shell leaves itself out of its own list (isCurrentagainstApp.config.basePath). Icons come from each shell's own registration, with a fallback map. Reachability stays the platform's business: a shell your roles don't allow answers 403 when opened, exactly as it does from Home — the listing has never been role-filtered and this doesn't invent that.The markup is a dozen lines per shell (each shell owns its own chrome); the logic lives in
application-core, once. The six shells: Applications, Personal, Partner, Administration, Monitoring, Builder.2. The legacy Dashboard shell is no longer registered
It was superseded by the Harmonia shells and Home already hid it — but the IDE's Window ▸ Shells menu listed it anyway, offering the old AngularJS/BlimpKit dashboard as a peer of the shells that replaced it. Removing its
platform-shellsextension drops it from both surfaces at once. The module itself stays: the generated views still loaddashboard/services/*. With nothing left to hide, Home'sHIDDENlist becomes empty.3. Why none of this was showing up: a 30-day cache on the menus
menus.jsandshells.jsansweredpublic, must-revalidate, max-age=2592000with a random-UUID ETag. So the browser served a month-old menu without asking the server, and the ETag could never match even when it did ask. That is why the "My Work" → "Personal" rename never appeared in an open IDE's Window menu, and why a newly published shell looked missing.Both now answer
private, no-cache(matching the projections service): this is content, re-aggregated whenever an artefact is published, not a static asset. Verified on a running instance:Correct labels, no Dashboard. The same defect exists on
perspectives.js/views.js/editors.js/themes.js/templates.js/locales.js— left alone here since the Window menu aggregates its content server-side, but worth a follow-up.Verification
mvn -T 1C clean install -P quick-build— green.ShellSwitcherIT(2 tests) — opens the menu in two different shells and asserts each lists the others plus Home, and omits itself.MonitoringShellIT(2) still green.🤖 Generated with Claude Code