feat: show weekly downloads on the extension detail page - #2135
Open
netomi wants to merge 3 commits into
Open
Conversation
netomi
force-pushed
the
split/weekly-downloads-card
branch
from
September 2, 2026 16:09
2736ee7 to
347270c
Compare
netomi
force-pushed
the
split/weekly-downloads-card
branch
from
September 3, 2026 14:46
40e2c5f to
5a246b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 6 of 6. Split out of #2027. Base: #2134 (
split/download-analytics).All three commits are @gnugomez's, cherry-picked with
-x, and they applied cleanly.The visible end of the feature: a weekly-downloads card on the extension detail page, fed by the series endpoint from #2134.
weekly-downloads.tsxanduse-extension-download-series.tsextension-registry-service.ts/extension-registry-types.tsextension-detail-overview.tsxIt reads
analyticsEnabledfrom/api/version, so on a registry with analytics off nothing is requested and nothing is rendered — which is every deployment by default.Why it is last
It is the only part of #2027 with a dependency in both directions: it needs the page primitives and
Pillfrom #2130, and the series endpoint from #2134. Landing it earlier would have meant either stubbing the endpoint or shipping a card with nothing behind it.Verification
yarn test281 passing across 55 files (274 from #2130 plus 7 here),yarn lintclean,tsc --noEmitclean.Stack summary
mainTwo of those carry things worth deciding rather than just reviewing: #2132 is a rewrite of live download counting that #2027's "disabled by default" framing hides, and #2134 is where a synchronous time-series write lands on the download request path.
Refs #2027, #2025