Skip to content

Enhance Javadoc for non-dynamic Image constructors#3383

Merged
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
HeikoKlare:javadoc-image-static-constructors
Jun 17, 2026
Merged

Enhance Javadoc for non-dynamic Image constructors#3383
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
HeikoKlare:javadoc-image-static-constructors

Conversation

@HeikoKlare

Copy link
Copy Markdown
Contributor

Images may be requested at different zooms, depending on the context and which they are used. Most types of images are able to generate image data for different zooms from their data source, such as an ImageDataProvider or ImageGcDrawer. The Image constructors accepting width and height or a Rectangle reflecting width and heights are usually used together with a GC that drawn on them. This usually produces proper image data for one zoom only.

This change enhances the Javadoc of those constructors to emphasize that they should only be used if none of the other constructors, in particular the one accepting an ImageGcDrawer, are applicable. For this, a statement about limitations for Windows ME and older are removed.

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Test Results

  188 files  ±0    188 suites  ±0   28m 1s ⏱️ + 2m 50s
4 733 tests ±0  4 710 ✅ ±0   23 💤 ±0  0 ❌ ±0 
6 867 runs  ±0  6 704 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 0cf5703. ± Comparison against base commit ddfc8d2.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the javadoc-image-static-constructors branch from e347071 to 63dd2a7 Compare June 13, 2026 14:31
@HeikoKlare HeikoKlare marked this pull request as ready for review June 13, 2026 14:47
@HeikoKlare HeikoKlare force-pushed the javadoc-image-static-constructors branch from 63dd2a7 to 134d221 Compare June 13, 2026 19:07
Images may be requested at different zooms, depending on the context and
which they are used. Most types of images are able to generate image
data for different zooms from their data source, such as an
ImageDataProvider or ImageGcDrawer. The Image constructors accepting
width and height or a Rectangle reflecting width and heights are usually
used together with a GC that drawn on them. This usually produces proper
image data for one zoom only.

This change enhances the Javadoc of those constructors to emphasize that
they should only be used if none of the other constructors, in
particular the one accepting an ImageGcDrawer, are applicable. For this,
a statement about limitations for Windows ME and older are removed.
@HeikoKlare HeikoKlare force-pushed the javadoc-image-static-constructors branch from 134d221 to 0cf5703 Compare June 17, 2026 13:36
@HeikoKlare HeikoKlare merged commit 3b02d06 into eclipse-platform:master Jun 17, 2026
31 of 32 checks passed
@HeikoKlare HeikoKlare deleted the javadoc-image-static-constructors branch June 17, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Javadoc for constructor Image(device, width, height)

1 participant