Remove the org.eclipse.ui.r30 from the Colors and Fonts theme selection.#4095
Open
elsazac wants to merge 1 commit into
Open
Remove the org.eclipse.ui.r30 from the Colors and Fonts theme selection.#4095elsazac wants to merge 1 commit into
elsazac wants to merge 1 commit into
Conversation
Contributor
Test Results 864 files + 2 864 suites +2 1h 2m 20s ⏱️ + 20m 36s For more details on these failures, see this check. Results for commit a7ffee0. ± Comparison against base commit 675a1a3. ♻️ This comment has been updated with latest results. |
elsazac
force-pushed
the
removeColorFontClassicTheme
branch
from
a916a59 to
b017f89
Compare
The Classic theme (org.eclipse.ui.r30) seems to be an old Eclipse 3.x theme that only contributes obsolete active-tab styling. Remove it from the Colors and Fonts preference page.
elsazac
force-pushed
the
removeColorFontClassicTheme
branch
from
b017f89 to
a7ffee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
org.eclipse.ui.r30theme seems to be an old eclipse 3.x workbench theme. Its contribution is now limited to a small set of active-tab styling overrides and it no longer provide a distinct visual experience from default theme. The theme is also unrelated to the former e4 Classic theme which was removed recently (org.eclipse.e4.ui.css.theme.e4_classic), although the shared "Classic" naming can make them appear connected. modern eclipse since relay on the e4 CSS theme framework for appearance, and theorg.eclipse.ui.r30overrides no longer result in a meaningful or distinguishable theme experience, thus could be removed imo.Contributes to eclipse-platform/eclipse.platform#2760