chore(bazel): align development-only dependencies - #1072
Closed
eclipse-score-bot wants to merge 1 commit into
Closed
eclipse-score-bot wants to merge 1 commit into
eclipse-score-bot wants to merge 1 commit into
Conversation
eclipse-score-bot
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 12, 2026 01:04
eclipse-score-bot
force-pushed
the
repo-policy-sync/dev-dependency-alignment
branch
from
September 19, 2026 01:05
87f8dff to
d682bb0
Compare
eclipse-score-bot
force-pushed
the
repo-policy-sync/dev-dependency-alignment
branch
from
September 22, 2026 08:57
d682bb0 to
6d91d1a
Compare
limdor
requested changes
Sep 22, 2026
limdor
left a comment
Contributor
There was a problem hiding this comment.
I do not see why this is not a dev dependency. In fact is not even a direct dependency, just a transitive one. It is transitive through baselibs and baselibs declares it as none dev.
To me it looks like the logic to deduce if it is a dev dependency or no is broken, it should only consider the code of this module and not the code of other modules.
Contributor
|
The plan is to delete it because it is not even used #1136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Policy
dev-dependency-alignmentKeep Bazel toolchain, lint, image, and documentation dependencies in the
intended dependency graph. The listed build-support dependencies are
development-only, while score_docs_as_code is used by the normal build graph.
Why this repository?
This repository matches this policy because
MODULE.bazeldeclares at least one of these direct Bazel dependencies:score_bazel_cpp_toolchains,buildifier_prebuilt,aspect_rules_lint,toolchains_llvm,score_rules_imagefs,score_docs_as_code.Changes
MODULE.bazel: remove dev_dependency from Bazel dependency 'score_docs_as_code'Tool revision
Generated from eclipse-score/tools at commit
5934dc0.This pull request is managed by SCORE Repository Policy Sync and may be updated by a later policy run.
Please report any issues to #score-infrastructure.
Note
This pull request is generated automatically. Review the proposed changes
before merging.