Skip to content

Normalise namespaces - #452

Merged
MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/fix-namespaces
Aug 12, 2026
Merged

MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/fix-namespaces

Conversation

@WilliamRoebuck

@WilliamRoebuck WilliamRoebuck commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor
  • score::lcm replaced with score::mw::lifecycle
  • score::mw::launch_manager replaced with score::mw::lifecycle
  • Remove using namespacess from headers
  • .clang-tidy had a syntax error, this has been fixed

Resolves #411

@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: f6243ea2-de7a-45b0-98ec-1641eebc2cf3
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (101 packages loaded, 26 targets configured)

Analyzing: target //:license-check (150 packages loaded, 3143 targets configured)

Analyzing: target //:license-check (159 packages loaded, 7043 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9348 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

Analyzing: target //:license-check (171 packages loaded, 9521 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[12 / 16] [Prepa] Generating Dash formatted dependency file ...
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.079s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown
Contributor

The created documentation from the pull request is available at: docu-html

@danth

danth commented Aug 12, 2026

Copy link
Copy Markdown
Member

Resolves #411 also

@danth

danth commented Aug 12, 2026

Copy link
Copy Markdown
Member

Looks good, build is failing however

Comment thread score/launch_manager/src/alive/src/details/AliveImpl.h Outdated
@WilliamRoebuck
WilliamRoebuck force-pushed the feature/fix-namespaces branch from e2e8837 to 194cb2f Compare August 12, 2026 13:55
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 12, 2026 13:55 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval August 12, 2026 13:55 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski merged commit 53c83ce into eclipse-score:main Aug 12, 2026
30 of 32 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 12, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — 194cb2f6 Deployed Aug 12, 2026 by WilliamRoebuck via Build and test unit-tests-x86_64-qnx / approval #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove all using namespace from headers

3 participants