Process Launcher Unit Test

[WilliamRoebuck]

98.5% line coverage for the file using syscall and osal mocks.

There are two remaining uncovered regions:

• std::to_chars error handling
  • Defensive programming. With all current implementations, this cannot happen as there are 15 bytes of space in the buffer and the possible integer longest would be 9 long.
• "Fork failed" case and log message
  • This is covered and the log can be observed, but the tooling seems not to recognise it

Some refactoring has been done to make the area more testable:

• Semaphore init/deinit methods extracted to IpcCommsSync static methods
• Added asserts instead of unreachable code
• WaitForkRunning/ignoreRunning combined into one function

One small bug fixed:

• A function that threw had been marked noexcept instead of noexcept(false)

[MaciejKaszynski]

Let's resolve the comments on the impl, then I'll look at the UT as it might change

[MaciejKaszynski]

Can all of this be put into mock_proc_launch_syscalls.hpp You have to scroll quite a bit to get to the actual test.