Conversation
- Removed unnecessary test directories and files. - Updated test names for clarity and consistency. - Added unit tests for `make_hello()` function. - Enhanced `make_hello_message()` function to utilize `make_hello()`. - Introduced new integration tests for module-level functionality. - Updated documentation references in the BUILD files.
AlexanderLanin
requested review from
PandaeDo,
RolandJentschETAS,
aschemmel-tech,
masc2023 and
pahmann
as code owners
September 11, 2026 06:59
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
| ├── docs/ # Global documentation of the module | ||
| │ ├── features/ # Feature documentation and architecture | ||
| │ │ └── <feature_name>/ # Folder for each feature parts which should be in module documentation | ||
| │ │ └── <feature_name>/ # Folder for each feature parts which should be in module documentation. Omit in single feature case. |
Contributor
There was a problem hiding this comment.
Omit subfolder in single feature case.
RolandJentschETAS
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize tests and enhance the structure of the component example. Introduce unit and integration tests for better coverage and clarity. Update documentation references and remove unnecessary files.
Resolves #130