Bump score_lifecycle pin and fix simple_lifecycle mw::com config - #350
Open
hskang-amelia wants to merge 2 commits into
Open
hskang-amelia wants to merge 2 commits into
hskang-amelia wants to merge 2 commits into
Conversation
hskang-amelia
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
September 21, 2026 04:03
hskang-amelia
force-pushed
the
bump-lifecycle-pin-fix-simple-lifecycle-mw-com
branch
2 times, most recently
from
September 21, 2026 04:12
cfc2048 to
0d7a5b2
Compare
Bumps score_lifecycle to the latest known-good hash and packages mw_com_config.json into the simple_lifecycle showcase so mw::com initializes correctly for components run by launch_manager. The config is staged both under etc/ (for launch_manager's own cwd) and bin/etc/ (for components chdir'd into bin_dir by ProcessGroupManager), since mw::com resolves the config path relative to each component's cwd at exec time.
hskang-amelia
force-pushed
the
bump-lifecycle-pin-fix-simple-lifecycle-mw-com
branch
from
September 21, 2026 07:25
bd23510 to
0876214
Compare
|
The created documentation from the pull request is available at: docu-html |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes, verified together against a real launch_manager run:
Bump
score_lifecyclefrom85da2168328d17a3cf53791ebf93534e5ed921fcto
9b86164ac1f850f76ac8ce743be903f98a60f422(current main), and migrateshowcases/simple_lifecycle/configs/launch_manager_config.jsonto the_msfield names/units that Use milliseconds directly in launch manager config schema lifecycle#637 introduced(already merged upstream; this repo's pin just hadn't caught up).
Package
mw_com_config.jsonfor thesimple_lifecycleshowcase.launch_managerand its supervised components (control_daemon,cpp_supervised_app,rust_supervised_app) all initialize mw::com'sLmControlService(ActivateRunTarget/GetActiveRunTarget), which needsa
mw_com_config.json.showcases/simple_lifecycle/BUILDnever packagedone — unlike
showcases/standalone/BUILD, which does — so on a real runlaunch_manageritself aborted immediately, and after fixing that,every supervised component still failed the same way and sat in
launch_manager's fallback restart loop, sinceProcessGroupManagerchdirs each component intobin_dirbefore exec'ing it — a differentdirectory than
launch_manager's own cwd.Why
Found while independently verifying eclipse-score/lifecycle#654 end-to-end
against this repo's
simple_lifecycleshowcase (the only place in this repothat exercises
launch_manager's realControlProvideralongside a realmw::com client). Neither issue is specific to #654 — both are pre-existing
gaps that just hadn't been exercised, since
simple_lifecyclewasn'trunnable end-to-end before this.
How
mw_com_config.jsonis the sameLmControlServiceservice definitionalready used by lifecycle's own integration tests (service id
7101,methods
ActivateRunTarget/GetActiveRunTarget).data/simple_lifecycle/etc/(via the existingcustom_layout, forlaunch_manager's own cwd) andbin/etc/(via asmall extra
pkg_filestarget passed throughother_package_files, foreach component's cwd) —
score_pkg_bundle'scustom_layoutcan onlyplace files under
data/NAME/, so it can't reachbin/etc/on its own.Testing
Built and ran the bundle end-to-end in
ghcr.io/eclipse-score/devcontainer:v1.11.0(this sandbox's host glibc istoo old for the Bazel-pulled Rust toolchain the bumped module needs):
Extracted and ran the resulting bundle directly:
launch_managerstartscleanly, supervises
control_daemon/cpp_supervised_app/rust_supervised_appwith no mw::com initialization errors, correctly transitions to the fallback
run target when
cpp_supervised_app'sSIGUSR1simulates a fault, and shutsdown with exit code 0 on
SIGTERM. Before this change,launch_manageraborted on startup (missing config) and, once that was worked around,
control_daemoncrash-looped every ~150ms indefinitely.🤖 Generated with Claude Code