feat: Quality pack targets by GabrielPinheiro7891 · Pull Request #150 · eclipse-score/time

GabrielPinheiro7891 · 2026-08-05T11:52:50Z

Provide Bazel targets: unit tests, component tests, code coverage.
Added documentation

github-actions · 2026-08-05T11:53:48Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: e636f4a8-a6b3-483f-b885-a7af3de54595
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'platforms', the root module requires module version platforms@1.0.0, but got platforms@1.1.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_platform', the root module requires module version score_platform@0.7.1, but got score_platform@0.7.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_oci', the root module requires module version rules_oci@2.2.7, but got rules_oci@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
INFO: Elapsed time: 14.317s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-08-05T11:58:19Z

The created documentation from the pull request is available at: docu-html

…ality-pack-targets

BjoernAtBosch · 2026-09-11T06:47:49Z

+   :id: doc__time_requirements
+   :status: valid
+   :version: 1
+   :safety: QM


Everything should be set to ASIL_B as the whole time library is ASIL now

BjoernAtBosch · 2026-09-11T07:04:19Z

+   :reqtype: Functional
+   :security: NO
+   :safety: QM
+   :derived_from: feat_req__time__high_prec_clock_api


Suggested change

:derived_from: feat_req__time__high_prec_clock_api

:derived_from: feat_req__time__high_res_clock_api

That did not change on main yet. So no change necessary.
PR that will include that change is still open and not merged

That requirement is in the S-CORE main repo: https://github.com/eclipse-score/score/blob/main/docs/features/time/requirements/index.rst#local-clock
(Was merged on 2026-09-04)

time/requirements/index.rst:30: comp_req__time__unified_clock_facade: is valid but links to invalid need(s): {'feat_req__time__high_res_clock_api'}
time/requirements/index.rst:105: comp_req__high_res_steady_time__snapshot: is valid but links to invalid need(s): {'feat_req__time__high_res_clock_api'}

It does not build with the change.

Only when #208 is merged you can do this change. On main at the moment what i have is the correct name

Ah - yes. Wasn't aware of that versioning, though this is actually obvious ...
I'd suggest to update the score_platform version to 0.7.2 in this PR then - not to linger on the old stuff.

Pr for updating the score_platform is already open: #208
Don't think it makes sense to update it here since there's already a pr for that

BjoernAtBosch · 2026-09-11T08:49:53Z

    srcs = ["high_res_steady_clock_adapter_test.cpp"],
    features = COMPILER_WARNING_FEATURES,
    tags = [
+        "component",


I don't think, that we should mark these as component tests because they do unit testing only.
Also, wondering if this combination of tags (component + unit) is possible.
But as shortly discussed on the call let's recheck documentation how this should be handled ...

BjoernAtBosch · 2026-09-11T08:51:23Z


 TEST(HighResSteadyClockTest, NowReturnsTimepointSuitableForDurationArithmetic)
 {
+    ::testing::Test::RecordProperty("FullyVerifies", "comp_req__high_res_steady_time__snapshot");


I don't think these tests (in general) do full verification of the requirement.
As mentioned in prev comment - we need to check docs ...

Co-authored-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com> Signed-off-by: Gabriel Pinheiro <gabriel.pinheiro@etas.com>

…ality-pack-targets

BjoernAtBosch

Hopefully some final comments

BjoernAtBosch · 2026-09-18T13:31:35Z

+   :reqtype: Functional
+   :security: NO
+   :safety: QM
+   :derived_from: feat_req__time__high_prec_clock_api


That requirement is in the S-CORE main repo: https://github.com/eclipse-score/score/blob/main/docs/features/time/requirements/index.rst#local-clock
(Was merged on 2026-09-04)

Co-authored-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com> Signed-off-by: Gabriel Pinheiro <gabriel.pinheiro@etas.com>

…ality-pack-targets

github-project-automation Bot added this to TIM - Time FT Aug 5, 2026

github-project-automation Bot moved this to In Progress in TIM - Time FT Aug 5, 2026

GabrielPinheiro7891 had a problem deploying to workflow-approval August 5, 2026 11:52 — with GitHub Actions Error

ryan-steel reviewed Aug 5, 2026

View reviewed changes

Comment thread docs/features/time/component_requirements.rst Outdated

GabrielPinheiro7891 had a problem deploying to workflow-approval August 6, 2026 14:22 — with GitHub Actions Error

GabrielPinheiro7891 requested a review from ryan-steel August 6, 2026 14:24

GabrielPinheiro7891 added 2 commits August 6, 2026 15:27

AZB #101279: Add Bazel targets for unit/component tests and coverage

64049ad

Update to match module_template

7444a7c

GabrielPinheiro7891 force-pushed the feature/AZB-101279-Quality-pack-targets branch from 160bc42 to 7444a7c Compare August 6, 2026 14:28

GabrielPinheiro7891 had a problem deploying to workflow-approval August 6, 2026 14:28 — with GitHub Actions Error

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

627b8c4

…ality-pack-targets

GabrielPinheiro7891 had a problem deploying to workflow-approval August 20, 2026 11:36 — with GitHub Actions Error

Update to match module_template and build

1cd949b

GabrielPinheiro7891 had a problem deploying to workflow-approval August 20, 2026 14:50 — with GitHub Actions Error

Fix alphabetical attribute ordering

f4be4e9

GabrielPinheiro7891 had a problem deploying to workflow-approval August 20, 2026 15:18 — with GitHub Actions Error

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

8355239

…ality-pack-targets

GabrielPinheiro7891 had a problem deploying to workflow-approval August 21, 2026 13:31 — with GitHub Actions Error

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

9f1840e

…ality-pack-targets

GabrielPinheiro7891 had a problem deploying to workflow-approval August 25, 2026 13:32 — with GitHub Actions Error

Merge requirements.rst into index.rst

635d30e

GabrielPinheiro7891 had a problem deploying to workflow-approval September 4, 2026 16:38 — with GitHub Actions Error

Clarify always-ready clock reqs: "prior initialization"

7df6383

GabrielPinheiro7891 had a problem deploying to workflow-approval September 4, 2026 16:43 — with GitHub Actions Error

BjoernAtBosch reviewed Sep 11, 2026

View reviewed changes

Apply batched suggestions from code review

1a63a6a

Co-authored-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com> Signed-off-by: Gabriel Pinheiro <gabriel.pinheiro@etas.com>

GabrielPinheiro7891 had a problem deploying to workflow-approval September 15, 2026 08:23 — with GitHub Actions Error

GabrielPinheiro7891 added 3 commits September 15, 2026 09:47

Align high-res steady clock test tags and requirement verification

a243508

add traceability gate and PR comment workflows

f02d560

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

2f414b1

…ality-pack-targets

GabrielPinheiro7891 had a problem deploying to workflow-approval September 15, 2026 09:15 — with GitHub Actions Error

Undo change to requirement name

22ef7b5

GabrielPinheiro7891 had a problem deploying to workflow-approval September 16, 2026 13:51 — with GitHub Actions Error

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

205ccb0

…ality-pack-targets

GabrielPinheiro7891 had a problem deploying to workflow-approval September 16, 2026 13:51 — with GitHub Actions Error

GabrielPinheiro7891 added 2 commits September 16, 2026 15:52

satisfy clang-format for high_res_steady_clock_adapter_test

dbd43e9

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

9114dd8

…ality-pack-targets

ryan-steel approved these changes Sep 17, 2026

View reviewed changes

ryan-steel mentioned this pull request Sep 18, 2026

Add ts client component requirements #149

Open

Merge branch 'main' into feature/AZB-101279-Quality-pack-targets

923d7e8

BjoernAtBosch reviewed Sep 18, 2026

View reviewed changes

GabrielPinheiro7891 and others added 3 commits September 23, 2026 12:31

Apply batched suggestions from code review

6610eee

Co-authored-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com> Signed-off-by: Gabriel Pinheiro <gabriel.pinheiro@etas.com>

Merge remote-tracking branch 'origin/main' into feature/AZB-101279-Qu…

3910ebb

…ality-pack-targets

Fix clang-format violations in vehicle_clock_test.cpp-

7c173ed

	:derived_from: feat_req__time__high_prec_clock_api
	:derived_from: feat_req__time__high_res_clock_api

Conversation

GabrielPinheiro7891 commented Aug 5, 2026

Uh oh!

github-actions Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

Uh oh!

BjoernAtBosch Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BjoernAtBosch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch is waiting to be deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 5, 2026 •

edited

Loading

BjoernAtBosch Sep 11, 2026 •

edited

Loading