Fix HTTP/2 codec flow control re-entrancy - #6359
Merged
Merged
Conversation
Motivation: VertxHttp2ConnectionHandler.writeData() explicitly called writePendingBytes() after encoding a data frame. When a stream's onWritabilityChanged() drained its outbound queue synchronously, the resulting writeData() re-entered the flow controller, triggering cascading writability notifications across other streams. Modifications: Remove the explicit writePendingBytes() call from writeData(). It is redundant: flush() already calls writePendingBytes() with built-in re-entrancy protection (inFlush/flushAgain guard). Result: No more flow controller re-entrancy during writability notifications. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
VertxHttp2ConnectionHandler.writeData()explicitly calledwritePendingBytes()after encoding a data frame. When a stream'sonWritabilityChanged()drained its outbound queue synchronously, theresulting
writeData()re-entered the flow controller, triggeringcascading writability notifications across other streams.
Modifications:
Remove the explicit
writePendingBytes()call fromwriteData(). It isredundant:
flush()already callswritePendingBytes()with built-inre-entrancy protection (inFlush/flushAgain guard).
Result:
No more flow controller re-entrancy during writability notifications.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com