Skip to content

fix(env): fix env detection compatibility for node, bun, and deno - #1037

Merged
plainheart merged 3 commits into
ecomfe:masterfrom
Uzlopak:bun-deno-node
Jun 28, 2024
Merged

fix(env): fix env detection compatibility for node, bun, and deno#1037
plainheart merged 3 commits into
ecomfe:masterfrom
Uzlopak:bun-deno-node

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

@plainheart

As discussed.

@sannajammeh

Copy link
Copy Markdown

#1046 related. Any progress on this?

@Uzlopak

Uzlopak commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

Well what progress do you expect when there is no feedback?

@sannajammeh

Copy link
Copy Markdown

There has been no new release in 4 months, although PRs are being merged no release has been made. @plainheart SSR is broken in Node 21 for apache echarts.

@plainheart

Copy link
Copy Markdown
Collaborator

@sannajammeh The fixes in PR #1036 should make it work for Node.js >= v21.1.0. As for the new release, we are preparing for Apache ECharts v5.5.0, the process will hopefully be done later this month.

@bangbang93

Copy link
Copy Markdown

4-month past. Any schedule for this?

@plainheart plainheart linked an issue Apr 11, 2024 that may be closed by this pull request
@plainheart
plainheart requested review from 100pah and pissang April 14, 2024 05:46
@plainheart
plainheart requested a review from Ovilia April 22, 2024 12:08
@plainheart
plainheart requested review from plainheart and removed request for 100pah, Ovilia and pissang May 8, 2024 03:09
@plainheart
plainheart merged commit 71bde87 into ecomfe:master Jun 28, 2024
@plainheart plainheart linked an issue Jun 28, 2024 that may be closed by this pull request
@Uzlopak
Uzlopak deleted the bun-deno-node branch June 28, 2024 07:28
@bangbang93

Copy link
Copy Markdown

any release schedule? node22 is lts now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

there is a bug with running on a without navigator.userAgent env SSR broken when Navigator object is defined. Node JS 21.

4 participants