updated for apptainer usage to suppress info warning in start#31
updated for apptainer usage to suppress info warning in start#31aprozo wants to merge 3 commits into
Conversation
❌ Deploy Preview for kaleidoscopic-syrniki-0cfb8a failed.
|
|
@veprbl could you please confirm? |
There was a problem hiding this comment.
Pull request overview
Updates the Singularity-based launcher generation to support Apptainer by preferring APPTAINER_BINDPATH and avoiding Apptainer’s “SINGULARITY_BINDPATH is preferred” startup warning.
Changes:
- Initialize
BINDPATHfromAPPTAINER_BINDPATH(falling back toSINGULARITY_BINDPATH). - In the generated
eic-shelllauncher, detect Apptainer via--versionand exportAPPTAINER_BINDPATH(unsettingSINGULARITY_BINDPATH) to suppress the warning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export EIC_SHELL_PREFIX=$PREFIX/local | ||
| export SINGULARITY_BINDPATH=$BINDPATH | ||
| if \${SINGULARITY:-$SINGULARITY} --version 2>&1 | grep -qi apptainer; then | ||
| export APPTAINER_BINDPATH=$BINDPATH | ||
| unset SINGULARITY_BINDPATH | ||
| else | ||
| export SINGULARITY_BINDPATH=$BINDPATH | ||
| fi |
There was a problem hiding this comment.
Updated the help text in commit 97e291e to document both APPTAINER_BINDPATH and SINGULARITY_BINDPATH, and added a note explaining that APPTAINER_BINDPATH is used (and SINGULARITY_BINDPATH is unset) when Apptainer is detected.
good catch Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…SINGULARITY_BINDPATH) Agent-Logs-Url: https://github.com/eic/eic-shell/sessions/0792ffc2-1bec-405e-b651-10b9bc85efaf Co-authored-by: aprozo <33087030+aprozo@users.noreply.github.com>
|
Thansk. Please first search for existing prs before opening new ones: #1 We have lots of stuff hanging in review purgatory all over the place. Adding duplicates doesn't really help with that. |
No more
when entering the container. It consumes my tokens each time i use it 😅
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
What is the urgency of this PR?
What kind of change does this PR introduce?