-
Notifications
You must be signed in to change notification settings - Fork 18
feat(factory): add --yes confirmation guard for destructive commands #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
margaretjgu
wants to merge
23
commits into
main
Choose a base branch
from
fix/destructive-confirmation-guard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6bfd24d
fix: infer destructive intent for cloud DELETE and known destructive …
margaretjgu e3951f8
fix: mark extension remove as destructive
margaretjgu 5f1480c
feat: add --yes confirmation guard for destructive commands
margaretjgu c794af5
chore: regenerate cli schema with --yes flag
margaretjgu cdc3e10
fix: use schema destructive flag for cloud commands
margaretjgu f113cbd
fix: lowercase yes flag help text
margaretjgu de1821e
test: add cloud destructive intent guard tests
margaretjgu 952aad0
chore: regenerate cli schema
margaretjgu 1412438
fix: pass yes flag in generated es delete tests
margaretjgu 606437a
fix: pass yes flag in kb functional delete calls
margaretjgu bcbadf6
ci: cap test node job at 10 minutes
margaretjgu 89b9267
test: fail individual tests after 20s not the job
margaretjgu 08eb210
test: drop dynamic import causing windows test hang
margaretjgu 3a4fc4b
test: raise per test timeout to 60s
margaretjgu af9e1f7
test: drop coverage flags to isolate windows hang
margaretjgu 2879832
test: rename confirmation test to check position dependence
margaretjgu cc35e86
test: revert to dynamic commander import, restore filename
margaretjgu b27b223
test: merge tty prompt cases back into one test
margaretjgu b8d0380
test: add diagnostic marker for real readline fallback
margaretjgu a873792
test: revert failed hang fixes, keep timeout diagnostics
margaretjgu cf5d16a
test: add isolated tty hang repro file
margaretjgu 5cb43ae
fix: stop mutating process.stderr.isTTY directly in tests
margaretjgu 9238e13
test: add diagnostics to isolate windows hang
margaretjgu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add another test here that uses
destructive: truerather than just trusting the@cli-schema/speclibrary to get intent right based on HTTP method?