build: replace the simdutf chromium patch with an electron-side include shim - #52958
Closed
codebytere wants to merge 1 commit into
Closed
build: replace the simdutf chromium patch with an electron-side include shim#52958codebytere wants to merge 1 commit into
codebytere wants to merge 1 commit into
Conversation
Node.js sources include simdutf as "simdutf.h", but Chromium's //third_party/simdutf target only supports the fully-qualified path and upstream declined adding a public include-dir config for us (https://chromium-review.googlesource.com/c/chromium/src/+/6642977). Node's GN build already lets embedders relocate simdutf via node_simdutf_path and only ever uses it as a dep label, so point it at //electron/build/simdutf: a group that re-exports //third_party/simdutf with its directory on the include path. Same single copy of simdutf, no patch on either side.
codebytere
added
semver/none
target/42-x-y
Member
Author
|
Actually closing in favor of nodejs/node#65382, we can delete then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Node.js and Chromium both vendor simdutf, so we build only Chromium's copy and point Node's GN build at it via
node_simdutf_path. Node's sources include it as"simdutf.h"though, and//third_party/simdutfdoesn't put its own directory on the include path, so we've been carrying a Chromium patch that adds a public config for that. Upstream declined the equivalent CL (https://chromium-review.googlesource.com/c/chromium/src/+/6642977).Node only ever uses
node_simdutf_pathas a dep label, so this points it at a small//electron/build/simdutfgroup that re-exports//third_party/simdutfwith the include dir attached, and deletes the patch. We still build a single copy of simdutf.Checklist
Release Notes
Notes: none