Use Operation.rot/2 for right-angle rotations#199
Merged
kipcole9 merged 1 commit intoJun 18, 2026
Conversation
Use `Operation.rot/2` for rotations that are multiples of 90 when no displacement options are set. Fall back to `Operation.rotate/3` otherwise.
Collaborator
|
@hlindset, thanks very much for the PR, gratefully accepted. I get a new version published in the next few hours. |
Collaborator
|
I've published Imaged version 0.69.0 with the following changelog entry: Enhancements
Thanks again for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
rotate/3to useOperation.rot/2as a fast path for rotations that are multiples of 90 when no displacement options are set. Falls back toOperation.rotate/3otherwise.This avoids resampling source pixels through an affine rotation when a discrete right-angle operation is possible.
Also updated the validation images for the +/- 90-degree rotation tests.
I adjusted the docs, but I'm not sure if the doc changes are in your style, or if you want it folded into the "Notes" section? If you accept this PR, feel free to change it however you like.