Remove redundant visited state from xref traversal - #15923
Merged
josevalim merged 1 commit intoSep 21, 2026
Merged
Conversation
Assisted-by: Codex:GPT-6
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Codex:GPT-6
source_treemaintains a result map and a separate visited map with identical keys. Both start empty and receive each vertex before descending into its dependencies, so the result map already provides the visited check.Remove the second map and tuple threading, preserving traversal order, cycle handling, and the distinction between missing vertices and empty adjacency lists. The separate state was necessary when traversal also filtered dependencies; that filtering moved outside the traversal in ef0cd4112.