Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/elixir/lib/module/types/descr.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4149,6 +4149,10 @@ defmodule Module.Types.Descr do
{required_keys, optional_keys, maybe_negated_set, required_domains, optional_domains}
end

defp map_split_keys_and_domains(:term) do
map_split_keys_and_domains(unfolded_term())
end

defp map_split_keys_and_domains(%{atom: {:union, atoms}} = key_descr) do
{:sets.to_list(atoms), [], nil, to_domain_keys(key_descr), []}
end
Expand Down
22 changes: 22 additions & 0 deletions lib/elixir/test/elixir/module/types/descr_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -2971,6 +2971,13 @@ defmodule Module.Types.DescrTest do
test "with projected negative maps" do
assert map_get(projected_negative_map(100), atom([:k])) == {:ok, open_map()}
end

test "with term() key considers atom fields" do
map = closed_map(a: {integer(), false})
assert map_get(map, term()) == {:ok, integer()}
assert map_get(map, term()) == map_get(map, atom())
assert map_get(open_map(a: {integer(), false}), term()) == {:ok, term()}
end
end

describe "map_update" do
Expand Down Expand Up @@ -3474,6 +3481,15 @@ defmodule Module.Types.DescrTest do
assert type == term()
assert equal?(descr, open_map(__struct__: {opt_negation(atom()), true}))
end

test "with term() key considers atom fields" do
{value, descr, _errors} =
map_update(closed_map(a: {integer(), false}), term(), atom([:x]), false)

assert equal?(value, integer())
assert subtype?(closed_map(a: {atom([:x]), false}), descr)
assert subtype?(closed_map(a: {integer(), false}), descr)
end
end

describe "map_put" do
Expand Down Expand Up @@ -3781,6 +3797,12 @@ defmodule Module.Types.DescrTest do
assert map_put(none(), atom([:a]), integer()) == :badmap
assert map_put(a2, atom([:a]), integer()) == :badmap
end

test "with term() key considers atom fields" do
{:ok, descr} = map_put(closed_map(a: {integer(), false}), term(), pid())
assert subtype?(closed_map(a: {pid(), false}), descr)
assert subtype?(closed_map(a: {integer(), false}), descr)
end
end

describe "disjoint" do
Expand Down