config: add hideSessionBar, drop the legacy config fallback - #104
Merged
Conversation
Setting "hideSessionBar": true in ~/.ellipsis/config.json removes the session nav under the text input. The chat window gets its rows, focus never leaves the chat, and the sidebar poll that only fed the nav is skipped. Config file only, no env var and no flag. Also removes the pre-0.17 read-only fallback to ~/.config/ellipsis: we are pre customer, so we move straight to the ideal end state instead of carrying migration paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two config changes:
hideSessionBarsetting. Setting"hideSessionBar": trueat the top level of~/.ellipsis/config.jsonremoves the session nav from the bottom of the interactive UI. It is a config-file setting only, by design: no env var, no CLI flag. When hidden:The setting lives at the top level rather than per host: it describes the terminal in front of the user, which is the same whichever host is active.
Legacy config fallback removed. The pre-0.17 read-only fallback to
~/.config/ellipsis/config.jsonis gone; the CLI now reads only~/.ellipsis/config.json(orELLIPSIS_CONFIG_DIR). We are pre customer, so we move straight to the ideal end state instead of carrying migration paths. Anyone with a config only at the old location will need toagent loginagain.Testing
hideSessionBar()(default false, reads true, non-boolean is false, survives a host write);test/config-legacy.test.tsdeleted with the fallback